Date: Fri, 3 Dec 2010 15:27:13 +0100 From: Ivan Voras <ivoras@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Bruce Cran <bruce@cran.org.uk>, src-committers@freebsd.org, svn-src-all@freebsd.org, Bruce Evans <brde@optusnet.com.au>, Bruce Cran <brucec@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r216134 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4v... Message-ID: <AANLkTinG%2BD=O0w61EVfAOYVagEXLO7TyB%2BNwdECmx%2BEF@mail.gmail.com> In-Reply-To: <201012030746.44967.jhb@freebsd.org> References: <201012022219.oB2MJUx5031472@svn.freebsd.org> <20101203201705.O2228@besplex.bde.org> <20101203101651.7461ced0@core.draftnet> <201012030746.44967.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3 December 2010 13:46, John Baldwin <jhb@freebsd.org> wrote: > On Friday, December 03, 2010 5:16:51 am Bruce Cran wrote: >> On Fri, 3 Dec 2010 20:45:12 +1100 (EST) >> Bruce Evans <brde@optusnet.com.au> wrote: >> >> > KASSERT() in little inline functions gives a lot of bloat for such an >> > unlikely error. =C2=A0Stupid callers can still pass any garbage count >> > except 0. >> >> Yes, this catches a specific case that hps raised a few years ago: >> sending zero-length packets/frames would fail by causing the system to >> hang. Should we just document the restriction in the man page and not >> try and prevent it at runtime? > > Documenting it is probably sufficient. I'd say it depends on if the "specific case that hps raised a few years ago" sentence part refers to an actual problem; i.e. did it happen in practice? If yes, leaving KASSERTs looks like the best option.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinG%2BD=O0w61EVfAOYVagEXLO7TyB%2BNwdECmx%2BEF>