Date: Sat, 24 Mar 2001 23:50:08 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Thomas Moestl <tmm@FreeBSD.org> Subject: RE: cvs commit: src/sys/alpha/include intrcnt.h src/sys/i386/i38 Message-ID: <Pine.BSF.4.21.0103242330440.28029-100000@besplex.bde.org> In-Reply-To: <XFMail.010323191857.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 23 Mar 2001, John Baldwin wrote: > On 24-Mar-01 John Baldwin wrote: > > > > On 23-Mar-01 Thomas Moestl wrote: > >> tmm 2001/03/22 19:45:17 PST > >> > >> Modified files: > >> sys/alpha/include intrcnt.h > >> sys/i386/i386 machdep.c > >> sys/i386/isa intr_machdep.c intr_machdep.h vector.s > >> sys/ia64/include intrcnt.h > >> sys/vm vm_meter.c > >> Added files: > >> sys/i386/include intrcnt.h > >> Log: > >> Export intrnames and intrcnt as sysctls (hw.nintr, hw.intrnames and > >> hw.intrcnt). > > > > Ewww. I'm not sure I like this, but ok. > > I should clarify. I don't mind removing setguid kmem from systat, but I think > that these interfaces are probably too machine dependent. I guess it is fine > for now, but please don't MFC this so we don't have to support this as an API > in the future. At some point there will be a MI intrsource abstraction that we > can bundle this into, and that will probably fit better. There is already a good MI abstraction (an array of interrupt counters and a string space of interrupt handler names). It is just declared in the wrong places. Utilities like systat and vmstat want a simple array that they can loop through, printing each element. They don't want to know any other details about interrupt handlers. The MD layers previously had to implement the layout require by the utilities. Now the MD layers are less constrained. The sysctl can hide any implementation details. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0103242330440.28029-100000>