Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Oct 2007 13:10:13 -0600
From:      Scott Long <scottl@samsco.org>
To:        d@delphij.net
Cc:        Andrey Chernov <ache@nagual.pp.ru>, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG
Subject:   Re: cvs commit: src/lib/libc/locale utf8.c
Message-ID:  <4720EA15.40002@samsco.org>
In-Reply-To: <4720E904.2090704@delphij.net>
References:  <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720E0AF.1010004@samsco.org> <4720E904.2090704@delphij.net>

next in thread | previous in thread | raw e-mail | index | archive | help
LI Xin wrote:
> Scott Long wrote:
>> Andrey Chernov wrote:
>>> On Thu, Oct 25, 2007 at 09:15:27AM -0600, Scott Long wrote:
>>>> Andrey A. Chernov wrote:
>>>>> ache        2007-10-15 09:51:30 UTC
>>>>>   FreeBSD src repository
>>>>>   Modified files:
>>>>>     lib/libc/locale      utf8.c   Log:
>>>>>   Add comment explaining __mb_sb_limit trick here.
>>>>>     Revision  Changes    Path
>>>>>   1.16      +5 -0      src/lib/libc/locale/utf8.c
>>>> When is the ABI damage from this going to be fixed?
>>> There is no ABI damage in -current.
>>>
>> Exposing the __mb_sb_limit symbol has instantly created a need
>> to have a compat7x package, and is causing many users problems
>> during upgrades and normal operations.  It may not be a problem
>> for you, Andre, but it's a problem for everyone else.  Please
>> respect this and fix it.
> 
> Well, I think the problem is not exposing a new symbol by itself, but
> __mb_sb_limit is being used in _ctype.h, in a form of __inline
> functions.  Therefore, the change will break new binaries running on
> older systems.  Personally I think this is acceptable, but maybe we
> could have a better way to avoid this, because the binaries are no
> longer backward compatible (i.e. you may have trouble running a program
> compiled for 6.3-RELEASE on 6.2-RELEASE, if it uses locale bits).

If this is true, then it directly violates the API/ABI compatability
guidelines that were developed and agreed to by the project in 2005.

Scott



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4720EA15.40002>