Date: Tue, 19 Apr 2016 11:23:12 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298219 - head/share/mk Message-ID: <9d854fa9-23b5-fd1c-8070-afaac8606f13@FreeBSD.org> In-Reply-To: <20160419121551.GX2422@kib.kiev.ua> References: <201604181814.u3IIE22P059301@repo.freebsd.org> <20160419121551.GX2422@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kwJDWVW71NLu9pQ0dviMIDM6gKT4Hj7Ew Content-Type: multipart/mixed; boundary="UI66GJwprXsHhPUoG4K4PUwdsreR4au1T" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <9d854fa9-23b5-fd1c-8070-afaac8606f13@FreeBSD.org> Subject: Re: svn commit: r298219 - head/share/mk References: <201604181814.u3IIE22P059301@repo.freebsd.org> <20160419121551.GX2422@kib.kiev.ua> In-Reply-To: <20160419121551.GX2422@kib.kiev.ua> --UI66GJwprXsHhPUoG4K4PUwdsreR4au1T Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 4/19/2016 5:15 AM, Konstantin Belousov wrote: > On Mon, Apr 18, 2016 at 06:14:02PM +0000, Bryan Drewery wrote: >> Author: bdrewery >> Date: Mon Apr 18 18:14:02 2016 >> New Revision: 298219 >> URL: https://svnweb.freebsd.org/changeset/base/298219 >> >> Log: >> Cause an error during 'make install' if trying to compile with CC. >> =20 >> This is limited to src-tree builds, meaning not extended to ports or= other >> out-of-tree builds. >> =20 >> This will help ensure that read-only OBJDIRS will be respected at in= stall-time >> by causing a more consistent failure for those who don't use a read-= only >> OBJDIR. It also will cause Jenkins to yell. This is a better solut= ion than >> trying to see CC=3Dfalse as has been attempted and discussed before.= >> =20 >> Of course this is only relevant for files generated by CC. >> =20 >> Disable this for META_MODE since it will detect the CFLAGS/command >> change and force a rebuild. >> =20 >> Sponsored by: EMC / Isilon Storage Division >> >> Modified: >> head/share/mk/bsd.sys.mk >> >> Modified: head/share/mk/bsd.sys.mk >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/share/mk/bsd.sys.mk Mon Apr 18 18:13:58 2016 (r298218) >> +++ head/share/mk/bsd.sys.mk Mon Apr 18 18:14:02 2016 (r298219) >> @@ -178,6 +178,13 @@ ACFLAGS+=3D ${ACFLAGS.${.IMPSRC:T}} >> CFLAGS+=3D ${CFLAGS.${.IMPSRC:T}} >> CXXFLAGS+=3D ${CXXFLAGS.${.IMPSRC:T}} >> =20 >> +.if defined(SRCTOP) >> +# Prevent rebuilding during install to support read-only objdirs. >> +.if make(install) && empty(.MAKE.MODE:Mmeta) >> +CFLAGS+=3D ERROR-tried-to-rebuild-during-make-install >> +.endif >> +.endif >> + >> # Tell bmake not to mistake standard targets for things to be searche= d for >> # or expect to ever be up-to-date. >> PHONY_NOTMAIN =3D analyze afterdepend afterinstall all beforedepend b= eforeinstall \ >=20 > It seems to cause the following behaviour: > make buildenv > cd lib/libthr > # make DEBUG_FLAGS=3D-g WITHOUT_TESTS=3Dyes all install > cc -O2 -pipe -DPTHREAD_KERNEL -I/usr/home/kostik/work/build/bsd/DEV= /src/lib/libthr/../libc/include -I/usr/home/kostik/work/build/bsd/DEV/src= /lib/libthr/thread -I/usr/home/kostik/work/build/bsd/DEV/src/lib/libthr/= =2E./../include -I/usr/home/kostik/work/build/bsd/DEV/src/lib/libthr/arch= /amd64/include -I/usr/home/kostik/work/build/bsd/DEV/src/lib/libthr/sys -= I/usr/home/kostik/work/build/bsd/DEV/src/lib/libthr/../../libexec/rtld-el= f -I/usr/home/kostik/work/build/bsd/DEV/src/lib/libthr/../../libexec/rtld= -elf/amd64 -I/usr/home/kostik/work/build/bsd/DEV/src/lib/libthr/../libthr= ead_db -Winline -fexceptions -D_PTHREAD_FORCED_UNWIND -D_PTHREADS_INVARIA= NTS -mno-mmx -mno-sse -mno-avx -g -MD -MP -MF.depend.thr_init.o -MTthr_in= it.o -std=3Dgnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-= unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith= -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-in= t -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value = -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-= unused-local-typedef -Qunused-arguments ERROR-tried-to-rebuild-during-m= ake-install -c /usr/home/kostik/work/build/bsd/DEV/src/lib/libthr/thread/= thr_init.c -o thr_init.o > cc: error: no such file or directory: 'ERROR-tried-to-rebuild-during-ma= ke-install' > *** Error code 1 >=20 > Stop. > make[3]: stopped in /usr/home/kostik/work/build/bsd/DEV/src/lib/libthr >=20 > Doing separate steps for all and install targets work, but before, it a= lso > worked and was convenient to list sequential targets on the make comman= d > line. >=20 I'll address this soon. --=20 Regards, Bryan Drewery --UI66GJwprXsHhPUoG4K4PUwdsreR4au1T-- --kwJDWVW71NLu9pQ0dviMIDM6gKT4Hj7Ew Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXFneRAAoJEDXXcbtuRpfP2aEIAJOGV9h2+q9rUGI8h4UAiROa RgFJYSgtCds2kFlfgorbEqEU0sdGfZyL+DbwUCeos+DR4iEvz2gNdMSCFPfiTN+T /G2ev3ZSsjq4AtCrazIefoUTZvmB2pGh1I9erwa72tfJCXxa6wDCa+FkCZaT8iNw ynQ55eSocgzg+2A823vrUQ9mdBG906TfrNa4GFw3CC1X8u43f2oqgjMsrJRZKXYB r5EZPXMegGq/4rMOuONrnpSbBwZ5uDiPIZZ7T/JJdbRnACKb9CyoRzmOU5SCZdp4 ldc2ydLOG/FxUjj51FRvPSdfICdTHnNPIQJsMhX/J22jplozwoEgd1d9wdnMSUA= =3/VB -----END PGP SIGNATURE----- --kwJDWVW71NLu9pQ0dviMIDM6gKT4Hj7Ew--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9d854fa9-23b5-fd1c-8070-afaac8606f13>