Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Nov 1996 17:18:14 PST
From:      Bill Fenner <fenner@parc.xerox.com>
To:        Kent Vander Velden <graphix@iastate.edu>
Cc:        Tom Samplonius <tom@sdf.com>, hackers@freefall.freebsd.org
Subject:   Re: ping and freebsd crashes 
Message-ID:  <96Nov24.171828pst.177567@crevenia.parc.xerox.com>
In-Reply-To: Your message of "Sun, 24 Nov 96 11:52:10 PST." <9611241952.AA18700@spiff.cc.iastate.edu> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <9611241952.AA18700@spiff.cc.iastate.edu> you write:
>  My mistake, it is rbootd that was concerning me.  These are the
>messages that get generated when it starts so I assume that this "bug"
>might give the machines that are running rbootd a problem
>"
>Oct 20 14:56:41 pseudo rbootd[175]: restarted (ed0)
>Oct 20 14:56:41 pseudo rbootd[175]: bpf: can't add mcast addr (Invalid
>argument), setting promiscuous mode
>Oct 20 14:56:41 pseudo /kernel: ed0: promiscuous mode enabled
>"

rbootd makes an interesting assumption, which doesn't appear to be
true on any bpf implementation that I know of, including bpf-1.1 from
LBL.  However, this patch might make it true for FreeBSD, allowing it
to not require promiscuous mode.  Would you please try it?

Thanks,
  Bill

Index: src/sys/net/bpf.c
*** bpf.c.orig	Sun Nov 24 23:58:41 1996
--- bpf.c	Mon Nov 25 00:08:22 1996
***************
*** 857,862 ****
--- 857,873 ----
  	case BIOCGRSIG:
  		*(u_int *)addr = d->bd_sig;
  		break;
+ 
+ 	/*
+ 	 * XXX ifioctl's first argument is the socket; we don't have
+ 	 * a socket.  SIOC{ADD,DEL}MULTI don't use the socket argument
+ 	 * so it is safe to pass in a null pointer.
+ 	 */
+ 	case SIOCADDMULTI:
+ 	case SIOCDELMULTI:
+ 		error = ifioctl(NULL, cmd, addr, p);
+ 		break;
+ 
  	}
  	return (error);
  }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96Nov24.171828pst.177567>