Date: Wed, 28 Jan 2004 02:31:40 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/61995: math/atlas-devel ia64 build fix Message-ID: <200401271731.i0RHVeaT012562@alph.allbsd.org> Resent-Message-ID: <200401271740.i0RHeDUS099711@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 61995 >Category: ports >Synopsis: math/atlas-devel ia64 build fix >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jan 27 09:40:13 PST 2004 >Closed-Date: >Last-Modified: >Originator: Hiroki Sato >Release: FreeBSD 4.8-STABLE i386 >Organization: Tokyo University of Science >Environment: System: FreeBSD alph.allbsd.org 4.9-RC FreeBSD 4.9-RC #0: Sat Oct 25 04:40:22 JST 2003 hrs@alph.allbsd.org:/usr/obj/usr/src/sys/ALPH i386 >Description: math/atlas-devel build on ia64 as of 2004/01/24 is broken due to the wrong files/answer file[*]. In the attached patch, files/answer is replaced with ${PRINTF}, a parameter set for ia64 is added, and some unnecessary "make xconfig" are eliminated. I am not sure if the parameter set is correct, but it worked on pluto2. [*] http://bento.freebsd.org/errorlogs/ia64-5-latest/atlas-devel-3.6.0.log And I think PKGNAMESUFFIX has to appear earlier (fixed in the patch), and the NO_PACKAGE is not reasonable for the purpose. Why don't you add the line into pkg-message instead? Even if the performance cannot be fully optimized, it is not a strong reason not to create the binary package. >How-To-Repeat: N/A >Fix: Index: math/atlas-devel/Makefile =================================================================== RCS file: /home/ncvs/ports/math/atlas-devel/Makefile,v retrieving revision 1.8 diff -d -u -I\$FreeBSD:.*\$ -I\$NetBSD:.*\$ -I\$OpenBSD:.*\$ -I\$Id:.*\$ -I\$hrs:.*\$ -r1.8 Makefile --- math/atlas-devel/Makefile 26 Jan 2004 13:41:47 -0000 1.8 +++ math/atlas-devel/Makefile 27 Jan 2004 17:20:05 -0000 @@ -13,6 +13,7 @@ CATEGORIES= math MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR= math-atlas +PKGNAMESUFFIX= -devel DISTNAME= ${PORTNAME}${PORTVERSION} MAINTAINER= maho@FreeBSD.org @@ -22,7 +23,6 @@ WRKSRC= ${WRKDIR}/ATLAS INSTALLS_SHLIB= yes USE_REINPLACE= yes -PKGNAMESUFFIX= -devel NO_PACKAGE= runtime performance heavily depends on building environment .include <bsd.port.pre.mk> @@ -59,20 +59,27 @@ .endif .endif +ANSWER_i386?= ${PRINTF} "\n\n\n\n\n\n\n\n\n\n" +ANSWER_ia64?= ${PRINTF} "\n\n\n2\n\n\n\n\nf77\n-O2 -static\n\n" + +.if !defined(ANSWER_${ARCH}) +ANSWER= ${ANSWER_i386} +.else +ANSWER= ${ANSWER_${ARCH}} +.endif + do-configure: - @(cd ${WRKSRC}; ${MAKE_ENV} ${MAKE} xconfig ; \ - ./xconfig -N 1 -c ${CC} -f ${FC} -a NON_THREADED < ${FILESDIR}/answer) - @(cd ${WRKSRC}; ${MAKE_ENV} ${MAKE} xconfig ; \ - ./xconfig -N 1 -c ${CC} -f ${FC} -a NON_THREADED_PIC \ + @(cd ${WRKSRC}; ${MAKE_ENV} ${MAKE} xconfig && \ + ${ANSWER} | ./xconfig -N 1 -c ${CC} -f ${FC} -a NON_THREADED && \ + ${ANSWER} | ./xconfig -N 1 -c ${CC} -f ${FC} -a NON_THREADED_PIC \ -F c '${PICFLAG} -DPIC' -F f '${PICFLAG} -DPIC' \ - -F m '${PICFLAG} -DPIC' -F x '${PICFLAG} -DPIC' < ${FILESDIR}/answer) - @(cd ${WRKSRC}; ${PATCH} < ${FILESDIR}/thread-patch) - @(cd ${WRKSRC}; ${MAKE_ENV} ${MAKE} xconfig ; \ - ./xconfig -c ${CC} -f ${FC} -a THREADED < ${FILESDIR}/answer) - @(cd ${WRKSRC}; ${MAKE_ENV} ${MAKE} xconfig ; \ - ./xconfig -c ${CC} -f ${FC} -a THREADED_PIC \ + -F m '${PICFLAG} -DPIC' -F x '${PICFLAG} -DPIC') + @(cd ${WRKSRC}; ${PATCH} < ${FILESDIR}/thread-patch && \ + ${MAKE_ENV} ${MAKE} xconfig && \ + ${ANSWER} | ./xconfig -c ${CC} -f ${FC} -a THREADED && \ + ${ANSWER} | ./xconfig -c ${CC} -f ${FC} -a THREADED_PIC \ -F c '${PICFLAG} -DPIC' -F f '${PICFLAG} -DPIC' \ - -F m '${PICFLAG} -DPIC' -F x '${PICFLAG} -DPIC' < ${FILESDIR}/answer) + -F m '${PICFLAG} -DPIC' -F x '${PICFLAG} -DPIC' ) ATLAS_LIBS1=libalapack libatlas libcblas libf77blas libtstatlas ATLAS_LIBS2=libptcblas libptf77blas Index: math/atlas-devel/files/answer =================================================================== RCS file: math/atlas-devel/files/answer diff -N math/atlas-devel/files/answer --- math/atlas-devel/files/answer 3 Oct 2003 23:15:36 -0000 1.1 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,10 +0,0 @@ - - - - - - - - - - >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200401271731.i0RHVeaT012562>