Date: Mon, 07 Jul 2008 16:33:41 -0400 From: Coleman Kane <cokane@FreeBSD.org> To: Alfred Perlstein <alfred@freebsd.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Ed Maste <emaste@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c Message-ID: <1215462821.2033.17.camel@localhost> In-Reply-To: <20080707195209.GD95574@elvis.mu.org> References: <200807032326.m63NQCdW044654@repoman.freebsd.org> <20080707195209.GD95574@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-sOl5lP5nr3dfx4pSXnJp Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2008-07-07 at 12:52 -0700, Alfred Perlstein wrote: > This really deserves a comment at each invocation of bcopy in > order to prevent regressions by someone "fixing" it again. >=20 > -Alfred >=20 > * Ed Maste <emaste@FreeBSD.org> [080703 16:26] wrote: > > emaste 2008-07-03 23:26:10 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/kern uipc_usrreq.c=20 > > Log: > > SVN rev 180238 on 2008-07-03 23:26:10Z by emaste > > =20 > > Use bcopy instead of strlcpy in uipc_bind and unp_connect, since > > soun->sun_path isn't a null-terminated string. As UNIX(4) states, "t= he > > terminating NUL is not part of the address." Since strlcpy has to re= turn > > "the total length of the string [it] tried to create," it walks off t= he end > > of soun->sun_path looking for a \0. > > =20 > > This reverts r105332. > > =20 > > Reported by: Ryan Stone > > =20 > > Revision Changes Path > > 1.215 +4 -2 src/sys/kern/uipc_usrreq.c >=20 Hopefully people will begin to incorporate "svn blame" into their work-flows. --=20 Coleman Kane --=-sOl5lP5nr3dfx4pSXnJp Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkhyfaIACgkQcMSxQcXat5d92gCfXHwFkzXzvQBPifvjrDXXpUj4 BOQAn2qRtZ/90cKxy/TOiPxU+OTJj1ah =urgU -----END PGP SIGNATURE----- --=-sOl5lP5nr3dfx4pSXnJp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1215462821.2033.17.camel>