Date: Wed, 21 Jan 2015 08:23:59 -0700 From: Will Andrews <will@firepipe.net> To: Lawrence Stewart <lstewart@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, imp@freebsd.org, Will Andrews <will@freebsd.org> Subject: Re: svn commit: r275832 - head/tools/tools/nanobsd Message-ID: <20150121152352.GB38973@sol.firepipe.net> In-Reply-To: <54BF5A7B.2080601@freebsd.org> References: <201412161759.sBGHx6ZL016021@svn.freebsd.org> <54BF5A7B.2080601@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--BwCQnh7xodEAoBMC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Jan 21, 2015 at 06:51:23PM +1100, Lawrence Stewart wrote:
> I think this change introduced a bug - I'm seeing nanobsd error out with
> the "NANO_TOOLS directory does not exist" message.
>=20
> The problem is that NANO_TOOLS is initialised to "tools/tools/nanobsd",
> and you changed the test in nanobsd.sh to *not* check for
> "${NANO_SRC}/${NANO_TOOLS}", which errors out except if the cwd is
> ${NANO_SRC}.
>=20
> You tweak NANO_TOOLS appropriately in set_defaults_and_export() but it's
> run after the dir test. There are a couple of ways to fix but I'll leave
> it to you to decide which you prefer.
Will this work for you?
https://people.freebsd.org/~will/patches/nanobsd.sh.diff
This also fixes another bug where NANO_PMAKE would be modified too early.
Thanks,
--Will.
--BwCQnh7xodEAoBMC
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlS/xIcACgkQF47idPgWcsVNYgCeJnWbAyN3HCbnEOMjjDdDyjcS
Nr8AoIjuvgf7DM/Jr6x9NJr/gYhTvvmn
=qGsa
-----END PGP SIGNATURE-----
--BwCQnh7xodEAoBMC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150121152352.GB38973>