Date: Thu, 15 Mar 2001 02:05:40 +0000 From: Paul Richards <paul@freebsd-services.co.uk> To: John Baldwin <jhb@FreeBSD.org> Cc: Maxim Sobolev <sobomax@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, David O'Brien <obrien@FreeBSD.org> Subject: Re: cvs commit: src/sys/netinet ip_output.c Message-ID: <3AB02374.55D5CE07@freebsd-services.co.uk> References: <XFMail.010314162749.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
>
> On 15-Mar-01 Paul Richards wrote:
> > John Baldwin wrote:
> >
> >> In 99.9% of the cases that Paul is mentioning, all one needs to do is 'cvs
> >> up'
> >> in ports/blah/foo/ (some things like kde and gnome don't do as well with
> >> this,
> >> but those aren't server apps) possibly dink with /var/db/port.mkversion,
> >> 'cvs
> >> up' ports/Mk, and rebuild and install the port. If for some reason it does
> >> fail, one can always file a PR if one is not able to fix it on one's own.
> >
> > Actually, on 0% of the cases would 'cvs up' have worked since the
> > current ports infrastructure doesn't work on 4.0, which is why I started
> > this whole thread in the first place.
>
> Odd, as my experiences in the past have been rather different. In fairness,
> I may not have done this since the addition of the -o option to pkg_*.
> However, I note that Nate has been using the current ports tree with 2.2.x with
> just a few minor tweaks, so I'm not sure why this is so impossibly difficult
> for you to manage. New-bus is by no means simple, so I'm sure if you can grok
The problem is ridiculously easy to fix but it's caused by a policy
decision to not support older releases. The fix is simply:
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.362
diff -r1.362 bsd.port.mk
1057c1057
< .if ${OSVERSION} >= 400000
---
> .if ${OSVERSION} > 400018
1418,1420c1418,1420
< .if ${BSDPORTMKVERSION} > ${SYSTEMVERSION}
< IGNORE= ": Your system is too old to use this bsd.port.mk. You need a
fresh make world or an upgrade kit. Please go to
http://www.FreeBSD.org/ports/ or a mirror site and follow the
instructions"
< .endif
---
> #.if ${BSDPORTMKVERSION} > ${SYSTEMVERSION}
> #IGNORE= ": Your system is too old to use this bsd.port.mk. You need a fresh make world or an upgrade kit. Please go to http://www.FreeBSD.org/ports/ or a mirror site and follow the instructions"
> #.endif
The OSVERSION is probably an actual bug since version 4000018 (4.0)
didn't have the -o option to pkg_create and it looks like that's what
that check is supposed to guard against. I didn't have a 4.1 box handy
so to really fix it the version number may need to be bigger than
4000018 to take account of 4.1 as well.
The real issue though is that the ports tree is broken by design with
respect to supporting older releases. How easy or not it is to make it
work with release X depends very much on what happens to have changed
between release X and -stable. In this case the change was trivial but
in any case, it still required an understanding of how ports work,
digging into the code to fix it up and circumventing the deliberate
policy of not supporting older releases.
Yes, I'm capable enough to do all that when I need to, the question is
should I have to or are we as a project making it more difficult for end
users than we need to.
> that you have the capacity to grok the ports tree. I don't think the ports
> tree is so overly complex that an admin can't figure it out and hack any small
> roadblocks he or she may encounter. Also, patches to fix these small problems
> that crop up by judicious use of FreeBSD_version are as always appreciated.
I dunno about your average admin messing with this sort of thing. While
many of them would be capable of it they don't want the hassle of having
to deal with it. Their day to day responsibilities are to keep the
company's services running and when they run into problems caused by the
OS they just call the OS vendor.
Paul.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3AB02374.55D5CE07>