Date: Sat, 21 Dec 2002 14:32:30 -0800 (PST) From: Nate Lawson <nate@root.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/usb umass.c Message-ID: <Pine.BSF.4.21.0212211427420.66919-100000@root.org> In-Reply-To: <200212211759.gBLHx0vB050926@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 21 Dec 2002, Matthew Dillon wrote: > :In message <20021221092828.N2810-100000@gamplex.bde.org>, Bruce Evans writes: > :>On Fri, 20 Dec 2002, Matt Dillon wrote: > :> > :>> dillon 2002/12/20 10:56:55 PST > :>> > :>> Modified files: > :>> sys/dev/usb umass.c > :>> Log: > :>> Modify the fake cylinders calculation so it is >= the size of the device, > :>> not < the size of the device. This avoids geom complaints. > :> > :>This was just another bug in geom. ccg->cylinders always gave the number of > :>full cylinders. > : > :GEOM doesn't even know about cylinders. > : > :-- > :Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > > hmm. It might have occured before I fixed the READ CAPACITY retry > bug(s). I'll try to reproduce it and back it out if I can't. Please test each of your changes independently if at all possible. I am sure this is not a bug in the calc routines as I checked their logic recently. If you find that I am wrong, the change can stay, otherwise please back out this portion of your commit. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0212211427420.66919-100000>