Date: Wed, 10 Jul 2013 11:38:45 -0600 From: "Justin T. Gibbs" <gibbs@FreeBSD.org> To: d@delphij.net Cc: freebsd-fs@freebsd.org, =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>, ivoras@freebsd.org, freebsd-hackers@freebsd.org Subject: Re: Make ZFS use the physical sector size when computing initial ashift Message-ID: <2B9367B6-8759-45C9-B120-9D00A381228F@FreeBSD.org> In-Reply-To: <51DD9801.4090808@delphij.net> References: <86zjtupz3r.fsf@nine.des.no> <51DD9801.4090808@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_4D9E9496-59FD-423A-B74B-D55D497C0941 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On Jul 10, 2013, at 11:21 AM, Xin Li <delphij@delphij.net> wrote: > Signed PGP part > On 07/10/13 02:02, Dag-Erling Sm=EF=BF=B8rgrav wrote: > > The attached patch causes ZFS to base the minimum transfer size for > > a new vdev on the GEOM provider's stripesize (physical sector size) > > rather than sectorsize (logical sector size), provided that > > stripesize is a power of two larger than sectorsize and smaller > > than or equal to VDEV_PAD_SIZE. This should eliminate the need for > > ivoras@'s gnop trick when creating ZFS pools on Advanced Format > > drives. >=20 > I think there are multiple versions of this (I also have one[1]) but > the concern is that if one creates a pool with ashift=3D9, and now > ashift=3D12, the pool gets unimportable. So there need a way to = disable > this behavior. >=20 > Another thing (not really related to the automatic detection) is that > we need a way to manually override this setting from command line when > creating the pool, this is under active discussion at Illumos mailing > list right now. >=20 > [1] > = https://github.com/trueos/trueos/commit/3d2e3a38faad8df4acf442b055c5e98ab8= 73fb26 >=20 > Cheers, > - --=20 > Xin LI <delphij@delphij.net> https://www.delphij.net/ > FreeBSD - The Power to Serve! Live free or die >=20 > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" I'm sure lots of folks have "some solution" to this. Here is an old version of what we use at Spectra: = http://people.freebsd.org/~gibbs/zfs_patches/zfs_auto_ashift.diff The above patch is missing some cleanup that was motivated by my discussions with George Wilson about this change in April. I'll dig that up later tonight. Even if you don't read the full diff, please read the included checkin comment since it explains the motivation behind this particular solution. This is on my list of things to upstream in the next week or so after I add logic to the userspace tools to report whether or not the TLVs in a pool are using an optimal allocation size. This is only possible if you actually make ZFS fully aware of logical, physical, and the configured allocation size. All of the other patches I've seen just treat physical as logical. -- Justin --Apple-Mail=_4D9E9496-59FD-423A-B74B-D55D497C0941 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.19 (Darwin) iQEcBAEBAgAGBQJR3ZwlAAoJED9n8CuvaSf4Aj0H/AgxokI9bUkCTo2Krp0PG6qJ BLPugsux3zOTmOoaChH41M9xEiPRu7wlzc7aHNqZQC8MDpk1LTTI81sfJ9M5e1UH DwSCvfRTp5NIBC4sgXt/z9mMogvI3HU1cn2TQp4AfCoKprBBiSnOSPXfp1tujxr6 LZWB0vAAQOlviBS/c4upPn5/gN8VC5qkudu2cLnS+XVxq/udkttjHnLXxV87Lh8/ Dw+R5wAKlAGUMlXTmSc4mJmMxi5jsqxgQ7izNPOwZqZooETSNIOfT9E6Ppl4n+DW CZYHjorTFUCmXiXWCNAmUox00LJcYcrWZZA9sOaGj5FIQ5iMeUYkAbml8PaKQyU= =Znt+ -----END PGP SIGNATURE----- --Apple-Mail=_4D9E9496-59FD-423A-B74B-D55D497C0941--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2B9367B6-8759-45C9-B120-9D00A381228F>