Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Mar 2015 05:50:40 +0000 (UTC)
From:      "Andrey V. Elsukov" <ae@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r279684 - head/sys/netinet6
Message-ID:  <201503060550.t265oexx030384@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ae
Date: Fri Mar  6 05:50:39 2015
New Revision: 279684
URL: https://svnweb.freebsd.org/changeset/base/279684

Log:
  tcp6_ctlinput() doesn't pass MTU value to in6_pcbnotify().
  Check cmdarg isn't NULL before dereference, this check was in the
  ip6_notify_pmtu() before r279588.
  
  Reported by:	Florian Smeets
  MFC after:	1 week

Modified:
  head/sys/netinet6/in6_pcb.c

Modified: head/sys/netinet6/in6_pcb.c
==============================================================================
--- head/sys/netinet6/in6_pcb.c	Fri Mar  6 02:05:45 2015	(r279683)
+++ head/sys/netinet6/in6_pcb.c	Fri Mar  6 05:50:39 2015	(r279684)
@@ -645,7 +645,7 @@ in6_pcbnotify(struct inpcbinfo *pcbinfo,
 		 * know the value, notify.
 		 * XXX: should we avoid to notify the value to TCP sockets?
 		 */
-		if (cmd == PRC_MSGSIZE)
+		if (cmd == PRC_MSGSIZE && cmdarg != NULL)
 			ip6_notify_pmtu(inp, (struct sockaddr_in6 *)dst,
 					*(u_int32_t *)cmdarg);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201503060550.t265oexx030384>