Date: Sun, 22 Dec 2002 10:12:28 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: cvs-committers@FreeBSD.ORG, <cvs-all@FreeBSD.ORG> Subject: Re: cvs commit: src/sys/dev/usb umass.c Message-ID: <20021222095435.O7325-100000@gamplex.bde.org> In-Reply-To: <200212202357.gBKNvGno024098@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 20 Dec 2002, Matthew Dillon wrote: > :On Fri, 20 Dec 2002, Matt Dillon wrote: > : > :> dillon 2002/12/20 10:56:55 PST > :> > :> Modified files: > :> sys/dev/usb umass.c > :> Log: > :> Modify the fake cylinders calculation so it is >= the size of the device, > :> not < the size of the device. This avoids geom complaints. > : > :This was just another bug in geom. ccg->cylinders always gave the number of > :full cylinders. > : > :Bruce > > I can back that out, but has it been fixed in geom yet? I don't want > to back it out (and re-break usb umass storage) until its fixed in > geom. I don't use geom, and try not to look at it :-). I can't find where it complains actually. Most places, shouldn't care, but libdisk/disk.c rev.1.102 wanted the size to be an exact multiple of the number of cylinders. This was fixed in rev.1.109, so apparently disks that don't satisfy this occur in nature for more than umass. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021222095435.O7325-100000>