Skip site navigation (1)Skip section navigation (2)


| raw e-mail | index | archive | help
    if: guard against if_ioctl being NULL

    There are situations where an struct ifnet has a NULL if_ioctl pointer.

    For example, e6000sw creates such struct ifnets for each of its ports s=
o it
can
    call into the MII code.

    If there is then a link state event this calls do_link_state_change()
    -> rtnl_handle_ifevent() -> dump_iface() -> get_operstate() ->
    get_operstate_ether(). That wants to know if the link is up or down, so=
 it
tries
    to ioctl(SIOCGIFMEDIA), which doesn't go well if if_ioctl is NULL.

    Guard against this, and return EOPNOTSUPP.

    PR:             275920
    MFC ater:       3 days
    Approved by:    re (cperciva)
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

    (cherry picked from commit 43387b4e574043b78a58c8bcb7575161b055fce1)
    (cherry picked from commit 9a8a26aefb366ef6f497d48547a1562a1de566c1)

 sys/net/if.c | 3 +++
 1 file changed, 3 insertions(+)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?>