Date: Thu, 26 Mar 2015 09:30:30 +0100 (CET) From: Emeric POUPON <emeric.poupon@stormshield.eu> To: Hans Petter Selasky <hps@selasky.org> Cc: freebsd-net <freebsd-net@freebsd.org>, Adrian Chadd <adrian@freebsd.org> Subject: Re: Fragment questions Message-ID: <84441657.26248421.1427358630097.JavaMail.zimbra@stormshield.eu> In-Reply-To: <5512BB1A.9070900@selasky.org> References: <522774578.25519037.1426765109046.JavaMail.zimbra@stormshield.eu> <2047974073.25663527.1426858267777.JavaMail.zimbra@stormshield.eu> <550C5FC6.6020401@selasky.org> <CAJ-Vmo=LkFc4sqbBSVeLE=7adV1nCuRDUO4ECUv8r6EYp=Oezw@mail.gmail.com> <550C6D65.6070409@selasky.org> <CAJ-Vmo=a6nzfRFH1cu0VefGk1opJf4WAt6u7ugT0uRMbjWvA-A@mail.gmail.com> <1776547746.25937476.1427189208729.JavaMail.zimbra@stormshield.eu> <5512BB1A.9070900@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ok for the function. Please find the review here: https://reviews.freebsd.org/D2141 Regards, Emeric ----- Mail original ----- De: "Hans Petter Selasky" <hps@selasky.org> =C3=80: "Emeric POUPON" <emeric.poupon@stormshield.eu>, "Adrian Chadd" <adr= ian@freebsd.org> Cc: "freebsd-net" <freebsd-net@freebsd.org> Envoy=C3=A9: Mercredi 25 Mars 2015 14:41:46 Objet: Re: Fragment questions On 03/24/15 10:26, Emeric POUPON wrote: > Hello, > > Please find attached a proposal using atomic_fetchadd. > > Best Regards, > > Emeric Hi, Your proposal using atomic_fetchadd() looks fine to me. I think however we should define the code like a function, because the=20 htons() might be a macro, referring the input argument multiple times ... What do you think? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?84441657.26248421.1427358630097.JavaMail.zimbra>