Date: Tue, 7 Apr 2009 12:16:32 -0700 From: Navdeep Parhar <nparhar@gmail.com> To: FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: KLDs missing CTF information (patch attached) Message-ID: <d04e16b70904071216v2f4c57a6v9b6e9de7cab9c248@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
--0016364ec8685281e50466fbda97 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit It appears that the KLD build process is missing a ctfmerge at the end, and this results in KLDs with incomplete CTF information. Here is a patch that fixes this. I verified it on amd64 with various KLDs. Before: # ctfdump /boot/kernel/if_cxgb.ko | wc -l 2269 # ctfdump /boot/kernel/zfs.ko | wc -l 430 After: # ctfdump /boot/kernel/if_cxgb.ko | wc -l 6568 # ctfdump /boot/kernel/zfs.ko | wc -l 15032 It is wasteful to have CTF information in both the .ko and the .ko.symbols file but this is what the kernel does too. Regards, Navdeep --0016364ec8685281e50466fbda97 Content-Type: application/octet-stream; name="ctf-kld.patch" Content-Disposition: attachment; filename="ctf-kld.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ft8yyxoz0 ZGlmZiAtciBiM2Y0ZTZhODJhODYgc3lzL2NvbmYva21vZC5tawotLS0gYS9zeXMvY29uZi9rbW9k Lm1rCU1vbiBBcHIgMDYgMTM6NDc6MzkgMjAwOSAtMDcwMAorKysgYi9zeXMvY29uZi9rbW9kLm1r CVR1ZSBBcHIgMDcgMTI6MDA6NTIgMjAwOSAtMDcwMApAQCAtMTI4LDYgKzEyOCwxMCBAQAogQ0ZM QUdTKz0JLW1sb25nY2FsbCAtZm5vLW9taXQtZnJhbWUtcG9pbnRlcgogLmVuZGlmCiAKKy5pZiBk ZWZpbmVkKERFQlVHKSB8fCBkZWZpbmVkKERFQlVHX0ZMQUdTKQorQ1RGRkxBR1MrPQktZworLmVu ZGlmCisKIC5pZiBkZWZpbmVkKEZJUk1XUykKIC5pZiAhZXhpc3RzKEApCiAke0tNT0Q6Uy8kLy5j L306IEAKQEAgLTE5Myw2ICsxOTcsOSBAQAogJHtGVUxMUFJPR306ICR7T0JKU30KIC5lbmRpZgog CSR7TER9ICR7TERGTEFHU30gLXIgLWQgLW8gJHsuVEFSR0VUfSAke09CSlN9CisuaWYgZGVmaW5l ZChDVEZNRVJHRSkKKwkke0NURk1FUkdFfSAke0NURkZMQUdTfSAtbyAkey5UQVJHRVR9ICR7T0JK U30KKy5lbmRpZgogLmlmIGRlZmluZWQoRVhQT1JUX1NZTVMpCiAuaWYgJHtFWFBPUlRfU1lNU30g IT0gWUVTCiAuaWYgJHtFWFBPUlRfU1lNU30gPT0gTk8K --0016364ec8685281e50466fbda97--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d04e16b70904071216v2f4c57a6v9b6e9de7cab9c248>