Date: Sat, 21 Dec 2002 17:20:40 -0800 (PST) From: Nate Lawson <nate@root.org> To: Matt Dillon <dillon@FreeBSD.org> Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org Subject: Re: cvs commit: src/sys/dev/usb umass.c Message-ID: <Pine.BSF.4.21.0212211439200.66919-100000@root.org> In-Reply-To: <20021220185703.6D4F137B431@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 20 Dec 2002, Matt Dillon wrote: > Modified files: > sys/dev/usb umass.c > Log: > Modify the fake cylinders calculation so it is >= the size of the device, > not < the size of the device. This avoids geom complaints. See previous email -- I think this change is wrong and the problem lies elsewhere. > Fix a serious bug in the handling of the RS_NO_CLEAR_UA quirk. When we > go and insert the test-unit-ready command the umass_cam_quirk_cb() function > sets the status as if the READ_CAPACITY command suceeded when, in fact, it > did not. This leads to the CAM layer trying to use garbage in the return > buffer and panicing the system (or doing other bad things). This change looks correct. > Add a quirk entry for MSYSTEMS DISK-ON-KEY, which is sold under the Sony > brand as a solid state disk-on-key usb device. This device requires > several quirks to work properly. This appears correct. > Note that the disk-on-key device will not work properly until CAM also > gets a quirk entry for it, which has been submitted to the CAM maintainer, I have replied to your pr, kern/46386 > and you may have to temporarily uncomment the DELAY() as well. -current > does not properly wait for devices to power up so you may also have > to temporarily uncomment the DELAY(300000) to make your device work. > A solution must be found to that issue. I'd like to hear more about this one and see what it is in umass that is possibly rescanning too fast. Maybe there should be a SLOWPROBE quirk there for this. Is the device in spec? -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0212211439200.66919-100000>