Date: Mon, 12 Dec 2005 16:45:32 -0800 From: Marcel Moolenaar <marcel@xcllnt.net> To: Warner Losh <imp@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 88102 for review Message-ID: <3D3166CC-DBC3-45C1-B78B-5CFE5F57C580@xcllnt.net> In-Reply-To: <200512122158.jBCLwwCt085740@repoman.freebsd.org> References: <200512122158.jBCLwwCt085740@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 12, 2005, at 9:58 PM, Warner Losh wrote: > http://perforce.freebsd.org/chv.cgi?CH=88102 > > Change 88102 by imp@imp_Speedy on 2005/12/12 21:58:35 > > Make uart_subr not depend on ns8250.o This is not such a good change. As the comment says in uart_subr.c, it's just a default. There's nothing PC specific about it. It's the the most common case and therefore a sensible default. Now, if it makes sense to have MD specific defaults and not MI defaults, then it makes sense to have ALL the defaults set in MD code and none in MI code (or if they are set in MI code, they should be set before MD defaults can be set to override the MI defaults). What really needs to be done is add support for the DT tag, so that you can set the device type in the environment.... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D3166CC-DBC3-45C1-B78B-5CFE5F57C580>