Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 7 Apr 2014 02:16:40 GMT
From:      Pedro Giffuni <pfg@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/188332: devel/libdispatch can be build with gcc in base
Message-ID:  <201404070216.s372Geu6062374@cgiserv.freebsd.org>
Resent-Message-ID: <201404070220.s372K0XU069538@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         188332
>Category:       ports
>Synopsis:       devel/libdispatch can be build with gcc in base
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 07 02:20:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Pedro Giffuni
>Release:        10.0-STABLE
>Organization:
>Environment:
FreeBSD kakumen 10.0-STABLE FreeBSD 10.0-STABLE #0 r263915M: Sat Mar 29 13:22:56 COT 2014     pfg@kakumen:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
Apple's GCC block support was backported to FreeBSD's gcc-4.2.1 in base (r260311).

With a small revision (r264121) which was MFCd to 10.0-STABLE as r264214, our base GCC got the capacity to build more blocks application cleanly.

This support is important for platforms lack support for clang like ia64, powerpc and sparc64.

The attached patch:
- Overrides the clang port option in platforms that ship a valid block-enabled compiler in base.
- Let's platforms like powerpc and sparc use the base compiler.
- Adds license information for libdispatch (Apache License 2.0)
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: libdispatch/Makefile
===================================================================
--- libdispatch/Makefile	(revision 350408)
+++ libdispatch/Makefile	(working copy)
@@ -10,6 +10,8 @@
 MAINTAINER=	brooks@FreeBSD.org
 COMMENT=	Grand Central Dispatch API support library
 
+LICENSE=	APACHE20
+
 USE_AUTOTOOLS=	aclocal autoconf
 ACLOCAL_ARGS=	-Im4
 GNU_CONFIGURE=	yes
@@ -18,10 +20,6 @@
 # This is needed because PIC support check in autoconf could fail for clang otherwise.
 CONFIGURE_ENV=	lt_cv_prog_compiler_pic_works=yes
 
-OPTIONS_DEFINE=	CLANG
-OPTIONS_DEFAULT=	CLANG
-CLANG_DESC=	Build with LLVM/Clang (required for blocks support)
-
 _MAN3=	dispatch.3 \
 	dispatch_after.3 \
 	dispatch_after_f.3 \
@@ -80,11 +78,17 @@
 
 .include <bsd.port.pre.mk>
 
+.if (${OSVERSION} < 1000024)
+OPTIONS_DEFINE=	CLANG
+OPTIONS_DEFAULT=	CLANG
+CLANG_DESC=	Build with LLVM/Clang (required for blocks support)
+.endif
+
 .if ${OSVERSION} <= 800107 || (${OSVERSION} >= 900000 && ${OSVERSION} < 900002)
 IGNORE=	is not supported on this OS version
 .endif
 
-.if ${OSVERSION} > 900000
+.if ((${OSVERSION} > 900000) && (${OSVERSION} < 1000706))
 .if ${ARCH} == "powerpc
 BROKEN=		Does not configure on powerpc-9
 .elif ${ARCH} == "sparc64


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404070216.s372Geu6062374>