Date: Fri, 4 Oct 2002 20:29:51 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: "Greg 'groggy' Lehey" <grog@FreeBSD.org> Cc: Terry Lambert <tlambert2@mindspring.com>, Emiel Kollof <coolvibe@hackerheaven.org>, Peter Wemm <peter@wemm.org>, Poul-Henning Kamp <phk@critter.freebsd.dk>, n0go013 <ttz@blahdeblah.demon.co.uk>, current <freebsd-current@FreeBSD.org> Subject: Re: [ GEOM tests ] disklabel warnings and vinum drives lost Message-ID: <Pine.NEB.3.96L.1021004202555.64999M-100000@fledge.watson.org> In-Reply-To: <20021005002350.GR72541@wantadilla.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 5 Oct 2002, Greg 'groggy' Lehey wrote: > FWIW, I've never seen this code. The dates on the patch suggest that > it was made in the last quarter of an hour: I didn't claim that this was his code. This was code I just wrote to address Vinum not finding the devices due to major/minor number changes. I was referring to a separate problem involving a zero'd sectorsize resulting in a divide by zero in the kernel, which Jeff reported experiencing and fixing previously. > > --- vinumio.c 21 Aug 2002 23:39:51 -0000 1.75 > > +++ vinumio.c 5 Oct 2002 00:03:09 -0000 > > However: > > RCS file: /home/ncvs/src/sys/modules/vinum/Makefile,v > revision 1.18 > date: 2000/04/16 00:17:46; author: grog; state: Exp; lines: +1 -3 > Remove MAINTAINER. > > Since that point, this particular file has had 5 updates, only one from > me. Jeff's a committer; he can commit it himself if he wants. Hmm. Funny, I was paying more attention to the line in the MAINTAINER's file which seems to suggest you are the maintainer. :-) Given that you appear to have read this patch -- may I commit it since it appears to resolve the first of the nits I ran into using Vinum with GEOM? There appear to be more problems in the tubes, but this one seemed straight-forward enough, especially since the functionality this patch replaces seems not to be in the tree. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1021004202555.64999M-100000>