Skip site navigation (1)Skip section navigation (2)
Date:      Wed,  8 Jul 2009 19:06:21 +0400 (MSD)
From:      Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/136465: [patch] ports-mgmt/portlint: fix bogus warnings in XXXDIR check
Message-ID:  <20090708150621.6514ADA81A@void.codelabs.ru>
Resent-Message-ID: <200907081510.n68FA1Z6080178@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         136465
>Category:       ports
>Synopsis:       [patch] ports-mgmt/portlint: fix bogus warnings in XXXDIR check
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 08 15:10:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Eygene Ryabinkin
>Release:        FreeBSD 8.0-BETA1 amd64
>Organization:
Code Labs
>Environment:

System: FreeBSD 8.0-BETA1 amd64

>Description:

Revision 1.99 of portlint.pl,
  http://www.freebsd.org/cgi/cvsweb.cgi/ports/ports-mgmt/portlint/src/portlint.pl.diff?r1=1.98;r2=1.99
added a very strict check for allowed combinations of PORTXXX and XXXDIR
in pkg-plist and alike.  This check produces false-positives on, for
example, devel/ruby-term-ansicolor,
-----
Do not mix %%PORTDOCS%% with %%RUBY_MODEXAMPLESDIR%%. Use
'%%PORTRUBY_MODEXAMPLES%%%%RUBY_MODEXAMPLESDIR%%/cdiff.rb' instead and
update Makefile accordingly.
-----
They are bogus, becase now there is no PORTRUBY_MODEXAMPLES
substitution.

>How-To-Repeat:

Go to devel/ruby-term-ansicolor and run 'portlint -A'.  Try to
find the mentioned variable PORTRUBY_MODEXAMPLES in /usr/ports/Mk.

>Fix:

--- portlint-fix-bogus-XXXDIR-warnings.diff begins here ---
begin 644 portlint-fix-bogus-XXXDIR-warnings.diff
M1G)O;2`Q,6$W.#1C9C<R9#`Q8C-E-F5E,C$X,V,X,V4R,#$X,S4W.3)C-34P
M($UO;B!397`@,3<@,#`Z,#`Z,#`@,C`P,0I&<F]M.B!%>6=E;F4@4GEA8FEN
M:VEN(#QR96$M9F)S9$!C;V1E;&%B<RYR=3X*1&%T93H@5V5D+"`X($IU;"`R
M,#`Y(#$X.C4V.C`P("LP-#`P"E-U8FIE8W0Z(%M0051#2%T@;F5T+6UG;70O
M<&]R=&QI;G0Z(&5L:6UI;F%T92!F86QS92UP;W-I=&EV97,@:6X@6%A81$E2
M(&-H96-K"@I2979I<VEO;B`Q+CDY(&]F('!O<G1L:6YT+G!L+`H@(&AT='`Z
M+R]W=W<N9G)E96)S9"YO<F<O8V=I+V-V<W=E8BYC9VDO<&]R=',O<&]R=',M
M;6=M="]P;W)T;&EN="]S<F,O<&]R=&QI;G0N<&PN9&EF9C]R,3TQ+CDX.W(R
M/3$N.3D*861D960@82!V97)Y('-T<FEC="!C:&5C:R!F;W(@86QL;W=E9"!C
M;VUB:6YA=&EO;G,@;V8@4$]25%A86"!A;F0@6%A81$E2"FEN('!K9RUP;&ES
M="!A;F0@86QI:V4N("!4:&ES(&-H96-K('!R;V1U8V5S(&9A;'-E+7!O<VET
M:79E<R!O;BP@9F]R"F5X86UP;&4L(&1E=F5L+W)U8GDM=&5R;2UA;G-I8V]L
M;W(L"BTM+2TM"D1O(&YO="!M:7@@)2503U)41$]#4R4E('=I=&@@)25254)9
M7TU/1$5804U03$531$E2)24N(%5S90HG)2503U)44E5"65]-3T1%6$%-4$Q%
M4R4E)25254)97TU/1$5804U03$531$E2)24O8V1I9F8N<F(G(&EN<W1E860@
M86YD"G5P9&%T92!-86ME9FEL92!A8V-O<F1I;F=L>2X*+2TM+2T*5&AE>2!A
M<F4@8F]G=7,L(&)E8V%S92!N;W<@=&AE<F4@:7,@;F\@4$]25%)50EE?34]$
M15A!35!,15,*<W5B<W1I='5T:6]N+@H*4VEG;F5D+6]F9BUB>3H@17EG96YE
M(%)Y86)I;FMI;B`\<F5A+69B<V1`8V]D96QA8G,N<G4^"BTM+0H@<&]R=',M
M;6=M="]P;W)T;&EN="]S<F,O<&]R=&QI;G0N<&P@?"`@(#$R("LK*RLK*RLK
M*RLK+0H@,2!F:6QE<R!C:&%N9V5D+"`Q,2!I;G-E<G1I;VYS*"LI+"`Q(&1E
M;&5T:6]N<R@M*0H*9&EF9B`M+6=I="!A+W!O<G1S+6UG;70O<&]R=&QI;G0O
M<W)C+W!O<G1L:6YT+G!L(&(O<&]R=',M;6=M="]P;W)T;&EN="]S<F,O<&]R
M=&QI;G0N<&P*:6YD97@@.#4T,V4R8RXN.#EB864R-B`Q,#`V-#0*+2TM(&$O
M<&]R=',M;6=M="]P;W)T;&EN="]S<F,O<&]R=&QI;G0N<&P**RLK(&(O<&]R
M=',M;6=M="]P;W)T;&EN="]S<F,O<&]R=&QI;G0N<&P*0$`@+38X,"PV("LV
M.#`L,34@0$`@<W5B(&-H96-K<&QI<W0@>PH@"6UY("1S965N7W-P96-I86P@
M/2`P.PH@"6UY("1I=&5M7V-O=6YT(#T@,#L*(`HK"2,@5F%R:6%B;&5S('1H
M870@87)E(&%L;&]W960@=&\@8F4@;W5T+6]F+7-Y;F,@:6X@=&AE"BL)(R!8
M6%A$25(@8VAE8VLN"BL)(R!%+F<N+"`E)5!/4E1$3T-3)24E)5)50EE?34]$
M1$]#1$E2)24@=VEL;"!B92!/2RP**PDC(&)E8V%U<V4@=&AE<F4@:7,@;F\@
M)2503U)44E5"65]-3T1$3T,E)2!S=6)S=&ET=71I;VXN"BL);7D@)6-H96-K
M7WAX>&1I<E]O:R`]("@**PD)(E)50EE?34]$1$]#(@D)"3T^(")$3T-3(BP*
M*PD)(E)50EE?34]$15A!35!,15,B"0D]/B`B1$]#4R(**PDI.PHK"B`);W!E
M;BA)3BP@(CP@)&9I;&4B*2!\?"!R971U<FX@,#L*(`EW:&EL92`H/$E./BD@
M>PH@"0DD:71E;5]C;W5N="LK.PI`0"`M.#DQ+#<@*SDP,"PX($!`('-U8B!C
M:&5C:W!L:7-T('L*(`D):68@*"1?(#U^(&U[7B4E4$]25"A<=RLI)24H+BH_
M*24E*%QW*RE$25(E)2@N*BDD?2!A;F0@)#$@;F4@)#,I('L*(`D)"29P97)R
M;W(H(E=!4DXB+"`D9FEL92P@)"XL(")$;R!N;W0@;6EX("4E4$]25"0Q)24@
M=VET:"`E)20S1$E2)24N("(N"B`)"0D)(E5S92`G)2503U)4)#,E)20R)24D
M,T1)4B4E)#0G(&EN<W1E860@86YD('5P9&%T92!-86ME9FEL92`B+@HM"0D)
M"2)A8V-O<F1I;F=L>2XB*3L**PD)"0DB86-C;W)D:6YG;'DN(BD@=6YL97-S
M("AD969I;F5D*"1C:&5C:U]X>'AD:7)?;VM[)#-]*2!A;F0**PD)"0D@("`@
M)&-H96-K7WAX>&1I<E]O:WLD,WT@97$@)#$I.PH@"0E]"B`*(`D):68@*"1?
M(#U^(&TC;6%N+RA;7B]=*R\I/VUA;BA;)&UA;F-H87!T97)S72DO*%M>7"Y=
L*UPN6R1M86YC:&%P=&5R<UTI*%PN9WHI/R0C*2!["BTM(`HQ+C8N,RXS"@H`
`
end
--- portlint-fix-bogus-XXXDIR-warnings.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090708150621.6514ADA81A>