Date: Tue, 28 Dec 2010 17:43:46 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, Ulrich Sp??rlein <uqs@spoerlein.net>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r216694 - head/libexec/rtld-elf Message-ID: <20101228154346.GT90883@deviant.kiev.zoral.com.ua> In-Reply-To: <201012281009.41028.jhb@freebsd.org> References: <201012250842.oBP8gchA016800@svn.freebsd.org> <20101228132942.GY23098@acme.spoerlein.net> <20101228133247.GR90883@deviant.kiev.zoral.com.ua> <201012281009.41028.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--iskw6J4cuOvZ6IVF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 28, 2010 at 10:09:40AM -0500, John Baldwin wrote: > On Tuesday, December 28, 2010 8:32:47 am Kostik Belousov wrote: > > On Tue, Dec 28, 2010 at 02:29:43PM +0100, Ulrich Sp??rlein wrote: > > > On Sat, 25.12.2010 at 08:42:38 +0000, Konstantin Belousov wrote: > > > > Author: kib > > > > Date: Sat Dec 25 08:42:38 2010 > > > > New Revision: 216694 > > > > URL: http://svn.freebsd.org/changeset/base/216694 > > > >=20 > > > > Log: > > > > Add a hook to pass debug flags to the build of rtld when doing ma= ke in > > > > the rtld directory. > > > > =20 > > > > Reviewed by: kan > > >=20 > > > Please revert this, $(VAR) is against style, and passing DEBUG_FLAGS = is > > > the canonical way to achieve what you wanted, eg. make DEBUG_FLAGS=3D= -g is > > > working just fine for me. > > DEBUG_FLAGS=3D-g might be fine for you, but it does not do what rtld de= bugging > > needs. Look at the -DDEBUG. > >=20 > > If you want ${} instead of $(), feel free to change. >=20 > Err, why can't you use 'make DEBUG_FLAGS=3D-DDEBUG' or > 'make DEBUG_FLAGS=3D"-g -DDEBUG"'? >=20 > If you are just doing 'make DEBUG=3D-DDEBUG' with this change, then I agr= ee > with Ulrich, DEBUG_FLAGS is already suitable for this purpose. >=20 I previously had a version that used RTLD_DEBUG, that I set from make.conf. Now I do make DEBUG_FLAGS=3D"-g" DEBUG=3D"-DDEBUG". The patch allows to force the compilation of dbg() without affecting global DEBUG_FLAGS setting= s. All big patches to rtld have -DDEBUG addition, and I tired trying to not forget removing them before the commit. Anyway, if somebody wants to revert the whole commit, feel free, I will return to local patching. --iskw6J4cuOvZ6IVF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk0aBbIACgkQC3+MBN1Mb4iJiwCgyxhO3ER2aOca2oPOIKEaIVPd WksAn1uGYQYnDgzcB/TWN8a289KbwAnP =8uXH -----END PGP SIGNATURE----- --iskw6J4cuOvZ6IVF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101228154346.GT90883>