Date: Thu, 4 Jun 2009 21:09:12 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193433 - head/sys/fs/devfs Message-ID: <20090604190912.GB1705@garage.freebsd.pl> In-Reply-To: <20090604190709.GA1705@garage.freebsd.pl> References: <200906041030.n54AUIh4084623@svn.freebsd.org> <20090604190709.GA1705@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--V0207lvV8h4k8FAm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 04, 2009 at 09:07:09PM +0200, Pawel Jakub Dawidek wrote: > On Thu, Jun 04, 2009 at 10:30:18AM +0000, Robert Watson wrote: > > Author: rwatson > > Date: Thu Jun 4 10:30:18 2009 > > New Revision: 193433 > > URL: http://svn.freebsd.org/changeset/base/193433 > >=20 > > Log: > > Re-add opt_mac.h include, which is required in order for MNT_MULTILAB= EL > > to be set properly on devfs. Otherwise, it isn't possible to set lab= els > > on /dev nodes. > > =20 > > Reported by: Sergio Rodriguez <sergiorr at yahoo.com> > > MFC after: 3 days >=20 > I'm afraid that's not the only case: >=20 > http://people.freebsd.org/~pjd/patches/opt_mac.patch I forgot to mention that even a compile test wasn't made and for dev/cxgb/ulp/tom/cxgb_cpl_io.c including opt_mac.h will trigger this: #ifdef MAC #error "no MAC support" #endif --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --V0207lvV8h4k8FAm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKKBvXForvXbEpPzQRAnMPAJ9VdvjtbDPYP6I/yjMJ4Im5NuEIGwCeOzTA A5kTbUH03kX3qcWku5dIYG4= =OXBh -----END PGP SIGNATURE----- --V0207lvV8h4k8FAm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090604190912.GB1705>