Date: Fri, 28 Dec 2007 15:12:15 +0100 (CET) From: Ed Schouten <ed@fxq.nl> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/119102: [Patch] x11-toolkits/xview: remove inclusion of sgtty Message-ID: <20071228141215.6A1251CCD9@palm.hoeg.nl> Resent-Message-ID: <200712281420.lBSEK38k054717@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 119102
>Category: ports
>Synopsis: [Patch] x11-toolkits/xview: remove inclusion of sgtty
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Dec 28 14:20:03 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator: Ed Schouten
>Release: FreeBSD 6.3-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD palm.hoeg.nl 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #0: Wed Dec 19 16:07:46 CET 2007 ed@palm.hoeg.nl:/usr/obj/usr/src/sys/PALM i386
>Description:
A nice thing about FreeBSD's xview port is that it uses the termios
interface for terminal handling. Unfortunately it still includes sgtty.h
in one place unconditionally, which will compilation errors if sgtty.h
would once be removed.
We'd better remove the useless inclusion.
>How-To-Repeat:
>Fix:
The following patch changes the existing to expandname.c to remove the
inclusion of sgtty.h.
--- x11-toolkits/xview/files/patch-lib+libxview+misc+expandname.c 2005-08-19 18:13:36.000000000 +0200
+++ x11-toolkits/xview/files/patch-lib+libxview+misc+expandname.c 2007-12-28 15:10:50.000000000 +0100
@@ -1,9 +1,11 @@
--- lib/libxview/misc/expandname.c.orig Tue Jun 29 07:16:30 1993
+++ lib/libxview/misc/expandname.c Fri Aug 19 15:53:44 2005
-@@ -23,14 +23,6 @@
+@@ -21,15 +21,6 @@
+ #include <sys/wait.h>
+ #include <stdio.h>
#include <string.h>
- #include <sgtty.h>
-
+-#include <sgtty.h>
+-
-#ifdef sparc
-#ifdef SVR4
-#include <unistd.h>
@@ -11,11 +13,10 @@
-#include <vfork.h>
-#endif SVR4
-#endif
--
+
#ifdef SVR4
#include <sys/signal.h>
- #endif SVR4
-@@ -120,7 +112,9 @@
+@@ -120,7 +111,9 @@
}
(void) close(pivec[0]);
#ifndef SVR4
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071228141215.6A1251CCD9>