Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Sep 2008 19:56:26 +0400
From:      Chagin Dmitry <dchagin@freebsd.org>
To:        Kostik Belousov <kostikbel@gmail.com>
Cc:        Alexander Leidinger <Alexander@leidinger.net>, freebsd-emulation@freebsd.org, freebsd-net@freebsd.org
Subject:   Re: [PATCH] recvmsg() sendmsg() linux emulation
Message-ID:  <20080918155626.GA3299@dchagin.dialup.corbina.ru>
In-Reply-To: <20080918153111.GL39652@deviant.kiev.zoral.com.ua>
References:  <20080822112946.GA97526@freebsd.org> <20080831110610.GA2380@dchagin.dialup.corbina.ru> <20080902085623.GA12395@freebsd.org> <20080917183801.GA2714@dchagin.dialup.corbina.ru> <20080917190230.GA2947@dchagin.dialup.corbina.ru> <20080918093831.89545e2iu5zjgjgg@webmail.leidinger.net> <20080918135736.GA2218@dchagin.dialup.corbina.ru> <20080918142454.GK39652@deviant.kiev.zoral.com.ua> <20080918150759.GA2898@dchagin.dialup.corbina.ru> <20080918153111.GL39652@deviant.kiev.zoral.com.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 18, 2008 at 06:31:11PM +0300, Kostik Belousov wrote:
> On Thu, Sep 18, 2008 at 07:07:59PM +0400, Chagin Dmitry wrote:
> 
> I still cannot answer to you, so be it.
> 
> > On Thu, Sep 18, 2008 at 05:24:54PM +0300, Kostik Belousov wrote:
> > > On Thu, Sep 18, 2008 at 05:57:36PM +0400, Chagin Dmitry wrote:
> > > > diff --git a/src/sys/amd64/linux32/linux32_io.h b/src/sys/amd64/linux32/linux32_io.h
> > > > new file mode 100644
> > > > index 0000000..c1a9f1c
> > > > --- /dev/null
> > > > +++ b/src/sys/amd64/linux32/linux32_io.h
> > > > @@ -0,0 +1,47 @@
> > > > +/*-
> > > > + * Copyright (c) 2004 Tim J. Robbins
> > > > + * Copyright (c) 2001 Doug Rabson
> > > > + * Copyright (c) 1994-1996 Søren Schmidt
> > > > + * All rights reserved.
> > > ^^^^^^^^^^ Is this true ?
> > > 
> > 
> > I have copied it from linux.h, can I remove it?
> 
> No, you should specify yourself as the copyright holder.
> 

ok

> > 
> > > Coloring this further, do we need a new include file for one structure
> > > and one function ?
> > > 
> > 
> > You suggest to transfer it to linux.h?
> > I can do it, but then it is necessary to insert #include <sys/uio.h>
> > into all files which include linux.h
> 
> This may be a trouble. Is there any other compat/linux include that
> requires uio ?

yes, linux_util.h include uio now, but iovec32 stuff specific only
for ia32@amd64 emulation.

-- 
Have fun!
chd



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080918155626.GA3299>