Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Sep 2013 22:57:14 GMT
From:      Fabian Keil <fk@fabiankeil.de>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   kern/181900: [patch] Line breaks missing in geli's kern.geom.confxml entries
Message-ID:  <201309062257.r86MvEDE033751@oldred.freebsd.org>
Resent-Message-ID: <201309062300.r86N00PF015701@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         181900
>Category:       kern
>Synopsis:       [patch] Line breaks missing in geli's kern.geom.confxml entries
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 06 23:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Fabian Keil
>Release:        HEAD
>Organization:
>Environment:
FreeBSD r500.local 10.0-CURRENT FreeBSD 10.0-CURRENT #597 r255153+2c13cb0: Fri Sep  6 13:19:19 CEST 2013     fk@r500.local:/usr/obj/usr/src/sys/ZOEY  amd64

>Description:
The attached patch adds two missing line breaks for geli's kern.geom.confxml entries.
>How-To-Repeat:
Attach geli provider, execute sysctl kern.geom.confxml, note missing line breaks for KeysTotal and KeysAllocated.
>Fix:


Patch attached with submission follows:

>From 1cf8de8c8b7d0c5b50f681bc8600d06cf57ac24e Mon Sep 17 00:00:00 2001
From: Fabian Keil <fk@fabiankeil.de>
Date: Wed, 4 Sep 2013 15:48:28 +0200
Subject: [PATCH] Add missing line breaks in geli's kern.geom.confxml entries

---
 sys/geom/eli/g_eli.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/geom/eli/g_eli.c b/sys/geom/eli/g_eli.c
index d6dcb4f..fc43372 100644
--- a/sys/geom/eli/g_eli.c
+++ b/sys/geom/eli/g_eli.c
@@ -1172,9 +1172,9 @@ g_eli_dumpconf(struct sbuf *sb, const char *indent, struct g_geom *gp,
 	if (pp != NULL || cp != NULL)
 		return;	/* Nothing here. */
 
-	sbuf_printf(sb, "%s<KeysTotal>%ju</KeysTotal>", indent,
+	sbuf_printf(sb, "%s<KeysTotal>%ju</KeysTotal>\n", indent,
 	    (uintmax_t)sc->sc_ekeys_total);
-	sbuf_printf(sb, "%s<KeysAllocated>%ju</KeysAllocated>", indent,
+	sbuf_printf(sb, "%s<KeysAllocated>%ju</KeysAllocated>\n", indent,
 	    (uintmax_t)sc->sc_ekeys_allocated);
 	sbuf_printf(sb, "%s<Flags>", indent);
 	if (sc->sc_flags == 0)
-- 
1.8.2.2



>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201309062257.r86MvEDE033751>