Date: Tue, 31 Jan 2006 23:58:58 -0800 From: Doug Barton <dougb@FreeBSD.org> To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/comms/conserver-com Makefile distinfo pkg-plist ports/comms/conserver-com/files conserver.sh conserver.sh.in Message-ID: <43E06A42.2030200@FreeBSD.org> In-Reply-To: <43E00A62.8090908@FreeBSD.org> References: <200601301402.k0UE2oKX097948@repoman.freebsd.org> <43E00A62.8090908@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Doug Barton wrote:
> Jun Kuriyama wrote:
>> kuriyama 2006-01-30 14:02:49 UTC
>>
>> FreeBSD ports repository
>>
>> Modified files:
>> comms/conserver-com Makefile distinfo pkg-plist
>> Added files:
>> comms/conserver-com/files conserver.sh.in
>> Removed files:
>> comms/conserver-com/files conserver.sh
>> Log:
>> - Upgrade to 8.1.13.
>> - Improve $USE_RC_SUBR usage.
>
> Overall this looks good, thanks! One nit though, it is no longer necessary
> to include the FreeBSD KEYWORD, as rc.subr doesn't need it. On the other
> hand, since I believe that this port is responsible for starting a daemon,
> it should probably include 'REQUIRE: DAEMON', and the shutdown KEYWORD. I'd
> be happy to make those changes if they are appropriate, just let me know.
>
> Regards,
>
> Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43E06A42.2030200>