Date: Mon, 14 Jun 2010 01:00:13 GMT From: Arifumi Matsumoto <a@arifumi.net> To: freebsd-net@FreeBSD.org Subject: Re: kern/143666: [ip6] [request] PMTU black hole detection not implemented Message-ID: <201006140100.o5E10D1M011093@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/143666; it has been noted by GNATS. From: Arifumi Matsumoto <a@arifumi.net> To: bug-followup@FreeBSD.org, freebsd-net@freebsd.org Cc: Subject: Re: kern/143666: [ip6] [request] PMTU black hole detection not implemented Date: Mon, 14 Jun 2010 09:32:11 +0900 --0016364ec9c29f44e80488f29edc Content-Type: text/plain; charset=ISO-8859-1 Hi, I made a patch for 8.0 release to fix this issue of path-mtu blackhole detection. This was mostly derived from macosx, which is APSL and BSD dual-licensed code base, and slightly modified so that it should not affect ipv4 path mtu detection. I tested it on 8.0 release only. I'm guessing this can be applied for CURRENT also, as the related code does not seem to be changed that much. Best regards, --0016364ec9c29f44e80488f29edc Content-Type: application/octet-stream; name="pmtud-blackhole.patch" Content-Disposition: attachment; filename="pmtud-blackhole.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gaekgauz0 ZGlmZiAtYyBuZXRpbmV0Lm9yZy90Y3BfdGltZXIuYyBuZXRpbmV0L3RjcF90aW1lci5jCioqKiBu ZXRpbmV0Lm9yZy90Y3BfdGltZXIuYwlTdW4gT2N0IDI1IDAxOjEwOjI5IDIwMDkKLS0tIG5ldGlu ZXQvdGNwX3RpbWVyLmMJTW9uIEp1biAxNCAwMzoxNzozMyAyMDEwCioqKioqKioqKioqKioqKgoq KiogNjEsNjYgKioqKgotLS0gNjEsNjcgLS0tLQogICNpbmNsdWRlIDxuZXRpbmV0L3RjcF9mc20u aD4KICAjaW5jbHVkZSA8bmV0aW5ldC90Y3BfdGltZXIuaD4KICAjaW5jbHVkZSA8bmV0aW5ldC90 Y3BfdmFyLmg+CisgI2luY2x1ZGUgPG5ldGluZXQ2L3RjcDZfdmFyLmg+CiAgI2luY2x1ZGUgPG5l dGluZXQvdGNwaXAuaD4KICAjaWZkZWYgVENQREVCVUcKICAjaW5jbHVkZSA8bmV0aW5ldC90Y3Bf ZGVidWcuaD4KKioqKioqKioqKioqKioqCioqKiAxMTAsMTE1ICoqKioKLS0tIDExMSwxMjMgLS0t LQogIFNZU0NUTF9QUk9DKF9uZXRfaW5ldF90Y3AsIE9JRF9BVVRPLCBmaW53YWl0Ml90aW1lb3V0 LCBDVExUWVBFX0lOVHxDVExGTEFHX1JXLAogICAgICAmdGNwX2ZpbndhaXQyX3RpbWVvdXQsIDAs IHN5c2N0bF9tc2VjX3RvX3RpY2tzLCAiSSIsICJGSU4tV0FJVDIgdGltZW91dCIpOwogIAorIGlu dCAgICAgdGNwX3BtdHVkX2JsYWNrX2hvbGVfZGV0ZWN0ID0gMSA7CisgU1lTQ1RMX0lOVChfbmV0 X2luZXRfdGNwLCBPSURfQVVUTywgcG10dWRfYmxhY2tob2xlX2RldGVjdGlvbiwgQ1RMRkxBR19S VywKKyAgICAgJnRjcF9wbXR1ZF9ibGFja19ob2xlX2RldGVjdCwgMCwgIlBhdGggTVRVIERpc2Nv dmVyeSBCbGFjayBIb2xlIERldGVjdGlvbiIpOworIAorIGludCAgICAgdGNwX3BtdHVkX2JsYWNr X2hvbGVfbXNzID0gMTIwMCA7CisgU1lTQ1RMX0lOVChfbmV0X2luZXRfdGNwLCBPSURfQVVUTywg cG10dWRfYmxhY2tob2xlX21zcywgQ1RMRkxBR19SVywKKyAgICAgJnRjcF9wbXR1ZF9ibGFja19o b2xlX21zcywgMCwgIlBhdGggTVRVIERpc2NvdmVyeSBCbGFjayBIb2xlIERldGVjdGlvbiBsb3dl cmVkIE1TUyIpOwogIAogIHN0YXRpYyBpbnQJdGNwX2tlZXBjbnQgPSBUQ1BUVl9LRUVQQ05UOwog IAkvKiBtYXggaWRsZSBwcm9iZXMgKi8KKioqKioqKioqKioqKioqCioqKiA0NDIsNDQ3ICoqKioK LS0tIDQ1MCw0NTggLS0tLQogIAlpbnQgcmV4bXQ7CiAgCWludCBoZWFkbG9ja2VkOwogIAlzdHJ1 Y3QgaW5wY2IgKmlucDsKKyAjaWZkZWYgSU5FVDYKKyAJaW50IG9wdGxlbiA9IDA7CisgI2VuZGlm CiAgI2lmZGVmIFRDUERFQlVHCiAgCWludCBvc3RhdGU7CiAgCioqKioqKioqKioqKioqKgoqKiog NTEzLDUxOCAqKioqCi0tLSA1MjQsNTcwIC0tLS0KICAJCXJleG10ID0gVENQX1JFWE1UVkFMKHRw KSAqIHRjcF9iYWNrb2ZmW3RwLT50X3J4dHNoaWZ0XTsKICAJVENQVF9SQU5HRVNFVCh0cC0+dF9y eHRjdXIsIHJleG10LAogIAkJICAgICAgdHAtPnRfcnR0bWluLCBUQ1BUVl9SRVhNVE1BWCk7Cisg CisgICAgICAgICAvKgorICAgICAgICAgICogQ2hlY2sgZm9yIHBvdGVudGlhbCBQYXRoIE1UVSBE aXNjb3ZlcnkgQmxhY2sgSG9sZSAKKyAgICAgICAgICAqLworIAorICNpZiBJTkVUNgorICAgICAg ICAgaWYgKCh0cC0+dF9pbnBjYi0+aW5wX3ZmbGFnICYgSU5QX0lQVjYpICE9IDAgJiYgdGNwX3Bt dHVkX2JsYWNrX2hvbGVfZGV0ZWN0ICYmICh0cC0+dF9zdGF0ZSA9PSBUQ1BTX0VTVEFCTElTSEVE KSkgeworICAgICAgICAgICAgICAgICBpZiAodHAtPnRfcnh0c2hpZnQgPT0gMikgeworICAgICAg ICAgICAgICAgICAgICAgICAgIC8qIAorICAgICAgICAgICAgICAgICAgICAgICAgICAqIEVudGVy IFBhdGggTVRVIEJsYWNrLWhvbGUgRGV0ZWN0aW9uIG1lY2hhbmlzbToKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgKiAtIERpc2FibGUgUGF0aCBNVFUgRGlzY292ZXJ5IChJUCAiREYiIGJpdCku CisgICAgICAgICAgICAgICAgICAgICAgICAgICogLSBSZWR1Y2UgTVRVIHRvIGxvd2VyIHZhbHVl IHRoYW4gd2hhdCB3ZSBuZWdvY2lhdGVkIHdpdGggcGVlci4KKyAgICAgICAgICAgICAgICAgICAg ICAgICAgKi8KKyAKKyAgICAgICAgICAgICAgICAgICAgICAgICB0cC0+dF9mbGFncyB8PSBURl9C TEFDS0hPTEU7IC8qIFJlY29yZCB0aGF0IHdlIG1heSBoYXZlIGZvdW5kIGEgYmxhY2sgaG9sZSAq LworICAgICAgICAgICAgICAgICAgICAgICAgIG9wdGxlbiA9IHRwLT50X21heG9wZCAtIHRwLT50 X21heHNlZzsKKyAgICAgICAgICAgICAgICAgICAgICAgICB0cC0+dF9wbXR1ZF9zYXZlZF9tYXhv cGQgPSB0cC0+dF9tYXhvcGQ7IC8qIEtlZXAgdHJhY2sgb2YgcHJldmlvdXMgTVNTICovCisgICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKHRwLT50X21heG9wZCA+IHRjcF9wbXR1ZF9ibGFja19o b2xlX21zcykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRwLT50X21heG9wZCA9 IHRjcF9wbXR1ZF9ibGFja19ob2xlX21zczsgLyogUmVkdWNlIHRoZSBNU1MgdG8gaW50ZXJtZWRp YXJ5IHZhbHVlICovCisgICAgICAgICAgICAgICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB0cC0+dF9tYXhvcGQgPSBWX3RjcF92Nm1zc2RmbHQ7Cisg ICAgICAgICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgICAgICAgICAgIHRwLT50 X21heHNlZyA9IHRwLT50X21heG9wZCAtIG9wdGxlbjsKKyAgICAgICAgICAgICAgICAgfQorICAg ICAgICAgICAgICAgICAvKgorICAgICAgICAgICAgICAgICAgKiBJZiBmdXJ0aGVyIHJldHJhbnNt aXNzaW9ucyBhcmUgc3RpbGwgdW5zdWNjZXNzZnVsIHdpdGggYSBsb3dlcmVkIE1UVSwKKyAgICAg ICAgICAgICAgICAgICogbWF5YmUgdGhpcyBpc24ndCBhIEJsYWNrIEhvbGUgYW5kIHdlIHJlc3Rv cmUgdGhlIHByZXZpb3VzIE1TUyBhbmQKKyAgICAgICAgICAgICAgICAgICogYmxhY2tob2xlIGRl dGVjdGlvbiBmbGFncy4KKyAgICAgICAgICAgICAgICAgICovCisgICAgICAgICAgICAgICAgIGVs c2UgeworIAorICAgICAgICAgICAgICAgICAgICAgICAgIGlmICgodHAtPnRfZmxhZ3MgJiBURl9C TEFDS0hPTEUpICYmICh0cC0+dF9yeHRzaGlmdCA+IDQpKSB7CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB0cC0+dF9mbGFncyAmPSB+VEZfQkxBQ0tIT0xFOyAKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG9wdGxlbiA9IHRwLT50X21heG9wZCAtIHRwLT50X21heHNl ZzsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRwLT50X21heG9wZCA9IHRwLT50 X3BtdHVkX3NhdmVkX21heG9wZDsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRw LT50X21heHNlZyA9IHRwLT50X21heG9wZCAtIG9wdGxlbjsKKyAgICAgICAgICAgICAgICAgICAg ICAgICB9CisgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgIH0KKyAjZW5kaWYKKyAKICAJLyoK ICAJICogRGlzYWJsZSByZmMxMzIzIGlmIHdlIGhhdm4ndCBnb3QgYW55IHJlc3BvbnNlIHRvCiAg CSAqIG91ciB0aGlyZCBTWU4gdG8gd29yay1hcm91bmQgc29tZSBicm9rZW4gdGVybWluYWwgc2Vy dmVycwpkaWZmIC1jIG5ldGluZXQub3JnL3RjcF92YXIuaCBuZXRpbmV0L3RjcF92YXIuaAoqKiog bmV0aW5ldC5vcmcvdGNwX3Zhci5oCVN1biBPY3QgMjUgMDE6MTA6MjkgMjAwOQotLS0gbmV0aW5l dC90Y3BfdmFyLmgJTW9uIEp1biAxNCAwOToyMToyNSAyMDEwCioqKioqKioqKioqKioqKgoqKiog MjAzLDIwOCAqKioqCi0tLSAyMDMsMjA5IC0tLS0KICAJaW50CXRfaXNwYXJlOwkJLyogZXhwbGlj aXQgcGFkIGZvciA2NGJpdCBhbGlnbm1lbnQgKi8KICAJdm9pZAkqdF9wc3BhcmUyWzZdOwkJLyog MiBDQyAvIDQgVEJEICovCiAgCXVpbnQ2NF90IF9wYWRbMTJdOwkJLyogNyBVVE8sIDUgVEJEICgx LTIgQ0MvUlRUPykgKi8KKyAgICAgICAgIHVfaW50ICAgdF9wbXR1ZF9zYXZlZF9tYXhvcGQ7ICAg LyogTVNTIHNhdmVkIGJlZm9yZSBwZXJmb3JtaW5nIFBNVFUtRCBCbGFja0hvbGUgZGV0ZWN0aW9u ICovCiAgfTsKICAKICAvKgoqKioqKioqKioqKioqKioKKioqIDIzNCwyMzkgKioqKgotLS0gMjM1 LDI0MSAtLS0tCiAgI2RlZmluZQlURl9FQ05fUEVSTUlUCTB4NDAwMDAwMAkvKiBjb25uZWN0aW9u IEVDTi1yZWFkeSAqLwogICNkZWZpbmUJVEZfRUNOX1NORF9DV1IJMHg4MDAwMDAwCS8qIEVDTiBD V1IgaW4gcXVldWUgKi8KICAjZGVmaW5lCVRGX0VDTl9TTkRfRUNFCTB4MTAwMDAwMDAJLyogRUNO IEVDRSBpbiBxdWV1ZSAqLworICNkZWZpbmUgVEZfQkxBQ0tIT0xFICAgIDB4MjAwMDAwMDAgICAg ICAvKiBQYXRoIE1UVSBEaXNjb3ZlcnkgQmxhY2sgSG9sZSBkZXRlY3Rpb24gKi8KICAKICAjZGVm aW5lIElOX0ZBU1RSRUNPVkVSWSh0cCkJKHRwLT50X2ZsYWdzICYgVEZfRkFTVFJFQ09WRVJZKQog ICNkZWZpbmUgRU5URVJfRkFTVFJFQ09WRVJZKHRwKQl0cC0+dF9mbGFncyB8PSBURl9GQVNUUkVD T1ZFUlkK --0016364ec9c29f44e80488f29edc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006140100.o5E10D1M011093>