Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Jun 2009 00:07:10 +0000 (UTC)
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r194044 - head/sys/arm/xscale/ixp425
Message-ID:  <200906120007.n5C07A5D063913@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: imp
Date: Fri Jun 12 00:07:09 2009
New Revision: 194044
URL: http://svn.freebsd.org/changeset/base/194044

Log:
  devclass_find_free_unit(xxx, 0) is identical to -1 for most
  applications (including this one).  Switch to it since the former is a
  racy interface.

Modified:
  head/sys/arm/xscale/ixp425/avila_ata.c

Modified: head/sys/arm/xscale/ixp425/avila_ata.c
==============================================================================
--- head/sys/arm/xscale/ixp425/avila_ata.c	Thu Jun 11 22:24:08 2009	(r194043)
+++ head/sys/arm/xscale/ixp425/avila_ata.c	Fri Jun 12 00:07:09 2009	(r194044)
@@ -248,7 +248,7 @@ ata_avila_attach(device_t dev)
 	    NULL, ata_avila_intr, sc, &sc->sc_ih);
 
 	/* attach channel on this controller */
-	device_add_child(dev, "ata", devclass_find_free_unit(ata_devclass, 0));
+	device_add_child(dev, "ata", -1);
 	bus_generic_attach(dev);
 
 	return 0;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906120007.n5C07A5D063913>