Date: Sat, 15 Jan 2000 08:08:31 -0800 From: Alfred Perlstein <bright@wintelcom.net> To: Greg Lehey <grog@lemis.com> Cc: "Matthew N. Dodd" <mdodd@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: How often to commit? (was: cvs commit: src/sys/i386/isa if_ex.c) Message-ID: <20000115080831.Q508@fw.wintelcom.net> In-Reply-To: <20000115130818.G349@mojave.worldwide.lemis.com>; from grog@lemis.com on Sat, Jan 15, 2000 at 01:08:18PM %2B0530 References: <200001130655.WAA06049@freefall.freebsd.org> <200001130652.WAA05820@freefall.freebsd.org> <200001130646.WAA05126@freefall.freebsd.org> <20000115130818.G349@mojave.worldwide.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* Greg Lehey <grog@lemis.com> [000115 07:25] wrote: > On Wednesday, 12 January 2000 at 22:46:03 -0800, Matthew N. Dodd wrote: > > mdodd 2000/01/12 22:46:03 PST > > > > Modified files: > > sys/i386/isa if_ex.c > > On Wednesday, 12 January 2000 at 22:52:52 -0800, Matthew N. Dodd wrote: > > mdodd 2000/01/12 22:52:52 PST > > > > Modified files: > > sys/i386/isa if_ex.c > > On Wednesday, 12 January 2000 at 22:55:35 -0800, Matthew N. Dodd wrote: > > mdodd 2000/01/12 22:55:35 PST > > > > Modified files: > > sys/i386/isa if_ex.c > > When I see messages like this, all containing relatively small > modifications, I wonder if we should come to some agreement on how > often a commit should be made for modules on which we're actively > working. I'm not picking on mdodd (well, only in the sense that I > noticed these three commits); I'm just wondering. I tend to go to the > other extreme myself, testing changes in some detail before making a > mega-commit. I suspect that the truth lies somewhere between these > two extremes. Would anybody like to discuss where it might be? I would agree, however looking at the diffs (if i am looking at the right ones) at: http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/i386/isa/Attic/if_ex.c shows that he has seperated bug fixes, new features and cosmetic changes pretty well. AFAIK that's what we usually encourage people to do so that changes made are clear. At the same time if those had been several commits consisting of essentially the same type of change, or just several 'oopsy's then I understand how it leads to bloat and a confusing sense of what's going on. OTOH I find that when _very_ large mega-commits are made and they aren't re-writes, meaning new-features, bug fixes and cosmetic changes made to old code, it can obscure changes and make it harder to debug. Because so much has changed and the delta is all three types of changes rolled into one, pinning down the source of a new problem becomes quite difficult. -Alfred To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000115080831.Q508>