Date: Wed, 9 Nov 2005 00:20:13 +0800 From: Ariff Abdullah <skywizard@MyBSD.org.my> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: freebsd-multimedia@freebsd.org, CQG00620@nifty.ne.jp Subject: Re: [patch] stereo input is mixed to monaural via SoundBlaster16 recording mixer Message-ID: <20051109002013.4dcf3c0d.skywizard@MyBSD.org.my> In-Reply-To: <20051108165955.ge235sro0848csok@netchild.homeip.net> References: <20051108153556.C856C253D6@mail.asahi-net.or.jp> <20051108165955.ge235sro0848csok@netchild.homeip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 08 Nov 2005 16:59:55 +0100 Alexander Leidinger <Alexander@Leidinger.net> wrote: > Watanabe Kazuhiro <CQG00620@nifty.ne.jp> wrote: > > > if (src & SOUND_MASK_MIC) > > - recdev |= 0x01; /* mono mic */ > > + recdev_l |= 0x01; /* mono mic */ > > + recdev_r |= 0x01; > > If I understand this correctly, this feeds the monaural signal to > the left and the right channel. When we have a mono input, do we > really want to have the same input doubled? I don't do any > recording, so I don't know how most programs handle this, but IMHO > it's a waste of resources and if the source is only able to deliver > a mono-signal, the recording should only be possible in mono. > > Does this sound sane? > Watanabe-san, I would suggest you to put braces along with the conditional statement so the code become much easier tu understand. Without it, it seems that recdev_r will always be set even if the condition is false. > Be warned, if you proceed to submit such patches, we may want to > lure you into becomming a committer... > -- Ariff Abdullah MyBSD http://www.MyBSD.org.my (IPv6/IPv4) http://staff.MyBSD.org.my (IPv6/IPv4) http://tomoyo.MyBSD.org.my (IPv6/IPv4)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051109002013.4dcf3c0d.skywizard>