Date: Wed, 29 Jul 2015 07:10:32 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Guido Falsi <madpilot@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r393097 - in head/graphics: gphoto2 gphoto2/files libgphoto2 libgphoto2/files Message-ID: <20150729071032.GA69069@FreeBSD.org> In-Reply-To: <201507282012.t6SKCkL5010769@repo.freebsd.org> References: <201507282012.t6SKCkL5010769@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 28, 2015 at 08:12:46PM +0000, Guido Falsi wrote: > New Revision: 393097 > URL: https://svnweb.freebsd.org/changeset/ports/393097 > > Log: > Update to 2.5.8 > > PR: 201845 > Submitted by: tkato432@yahoo.com Guys, Bear in mind that Kato's PRs often come with noise in the patches that should not be committed. Always review their submission thoroughly. > @@ -10,6 +10,7 @@ MAINTAINER= ports@FreeBSD.org > COMMENT= Command-line frontend to libgphoto2 > > LICENSE= GPLv2 > +#LICENSE_FILE= ${WRKSRC}/COPYING What was that supposed to mean, I wonder? :) > post-install: > - ${INSTALL_DATA} ${WRKSRC}/NEWS ${STAGEDIR}${DOCSDIR} > + (cd ${WRKSRC} && ${INSTALL_DATA} NEWS ${STAGEDIR}${DOCSDIR}) What this change was supposed to improve? It's longer, it now takes two commands instead of one, it requires grouping, etc. So how did it pass the review and got committed? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150729071032.GA69069>