Date: Thu, 31 Mar 2011 12:17:37 +0000 (UTC) From: Alexander Motin <mav@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r220191 - projects/graid/head/sys/geom/raid Message-ID: <201103311217.p2VCHbQ3005908@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mav Date: Thu Mar 31 12:17:37 2011 New Revision: 220191 URL: http://svn.freebsd.org/changeset/base/220191 Log: Fix unreachable code. It could cause not replacing more then one failed disk at a time on volumes with Promise metadata. Found with: Coverity Prevent(tm) CID: 9656 Modified: projects/graid/head/sys/geom/raid/md_promise.c Modified: projects/graid/head/sys/geom/raid/md_promise.c ============================================================================== --- projects/graid/head/sys/geom/raid/md_promise.c Thu Mar 31 12:03:30 2011 (r220190) +++ projects/graid/head/sys/geom/raid/md_promise.c Thu Mar 31 12:17:37 2011 (r220191) @@ -818,10 +818,10 @@ restart: } else update = 0; if (update) { + updated = 1; g_raid_md_write_promise(md, vol, NULL, disk); break; } - updated += update; } } if (updated)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103311217.p2VCHbQ3005908>