Date: Sat, 20 Dec 2008 17:07:36 +0100 (CET) From: Ulrich Spoerlein <uspoerlein@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: lioux@FreeBSD.org Subject: ports/129790: [PATCH] net-p2p/mldonkey: Fix rc start script Message-ID: <200812201607.mBKG7aNe004021@roadrunner.spoerlein.net> Resent-Message-ID: <200812201620.mBKGK1c9045675@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 129790
>Category: ports
>Synopsis: [PATCH] net-p2p/mldonkey: Fix rc start script
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Dec 20 16:20:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Ulrich Spoerlein
>Release: FreeBSD 7.1-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD roadrunner.spoerlein.net 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #0: Sat Nov 8 20:43:48 CET
>Description:
Hi, the start script of mlnet has two issues, since it is overwriting the
standard start_cmd routine. It doesn't print the "Starting mlnet." line
and does not check for an already running mlnet.
Fix this by copying the commands from rc.subr into this script.
Port maintainer (lioux@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:
--- mldonkey-2.9.6_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /tank/ncvs/ports/net-p2p/mldonkey/Makefile,v
retrieving revision 1.60
diff -u -p -u -r1.60 Makefile
--- Makefile 20 Aug 2008 00:57:10 -0000 1.60
+++ Makefile 20 Dec 2008 16:05:57 -0000
@@ -7,6 +7,7 @@
PORTNAME= mldonkey
PORTVERSION= 2.9.6
+PORTREVISION= 1
CATEGORIES+= net-p2p
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE_EXTENDED} \
${MASTER_SITE_SAVANNAH}
Index: files/mlnet.in
===================================================================
RCS file: /tank/ncvs/ports/net-p2p/mldonkey/files/mlnet.in,v
retrieving revision 1.3
diff -u -p -u -r1.3 mlnet.in
--- files/mlnet.in 26 Jul 2007 02:46:25 -0000 1.3
+++ files/mlnet.in 20 Dec 2008 16:05:57 -0000
@@ -53,6 +53,12 @@ start_cmd()
mlnet_logfile="/dev/null"
fi
+ if [ -n "$rc_pid" ]; then
+ echo 1>&2 "${name} already running? (pid=$rc_pid)."
+ return 1
+ fi
+
+ echo "Starting ${name}."
if [ "x${mlnet_user}" = "x$(whoami)" ]; then
eval "${command} \
${mlnet_logcommand} \
--- mldonkey-2.9.6_1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812201607.mBKG7aNe004021>