Date: Sat, 30 Mar 2013 03:29:28 GMT From: "r4721@tormail.org" <r4721@tormail.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/177491: [patch] fix display of port fail reasons on the latest_buildports page Message-ID: <201303300329.r2U3TSTi063344@red.freebsd.org> Resent-Message-ID: <201303300330.r2U3U0q9022936@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 177491
>Category: ports
>Synopsis: [patch] fix display of port fail reasons on the latest_buildports page
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 30 03:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: r4721@tormail.org
>Release:
>Organization:
>Environment:
>Description:
a missing echo causes the port fail reason to not be displayed on the latest_buildports page.
this patch has also been sent to the software vendor.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: ports-mgmt/tinderbox/files/patch-fail-reasons
===================================================================
--- ports-mgmt/tinderbox/files/patch-fail-reasons (revision 0)
+++ ports-mgmt/tinderbox/files/patch-fail-reasons (working copy)
@@ -0,0 +1,11 @@
+--- webui/templates/default/latest_buildports.tpl.orig
++++ webui/templates/default/latest_buildports.tpl
+@@ -50,7 +50,7 @@
+ <?php $reason=$row['port_last_fail_reason']?>
+ <td class="<?php if(!empty($port_fail_reasons[$reason]['type']))echo "fail_reason_".$port_fail_reasons[$reason]['type']?>">
+ <?php $href=isset($port_fail_reasons[$reason]['link']) ? "index.php?action=display_failure_reasons&failure_reason_tag=$reason#$reason" : "#"?>
+- <a href="<?php echo $href?>" class="<?php if(!empty($port_fail_reasons[$reason]['type']))echo "fail_reason_".$port_fail_reasons[$reason]['type']?>" title="<?php if(!empty($port_fail_reasons[$reason]['descr']))echo $port_fail_reasons[$reason]['descr']?>"><?php $reason?></a>
++ <a href="<?php echo $href?>" class="<?php if(!empty($port_fail_reasons[$reason]['type']))echo "fail_reason_".$port_fail_reasons[$reason]['type']?>" title="<?php if(!empty($port_fail_reasons[$reason]['descr']))echo $port_fail_reasons[$reason]['descr']?>"><?php echo $reason?></a>
+ </td>
+ <td>
+ <?php if($row['port_link_logfile']){?>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303300329.r2U3TSTi063344>