Date: Thu, 07 Nov 2013 14:11:03 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Alan Somers <asomers@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r252481 - in head: etc sbin/devd Message-ID: <527B8357.5070200@FreeBSD.org> In-Reply-To: <201307012120.r61LKIxI059332@svn.freebsd.org> References: <201307012120.r61LKIxI059332@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
First, apologies for this very delayed reaction. on 02/07/2013 00:20 Alan Somers said the following: > Author: asomers > Date: Mon Jul 1 21:20:17 2013 > New Revision: 252481 > URL: http://svnweb.freebsd.org/changeset/base/252481 > > Log: > Add syslog(3) support to devd(8). > [snip] > @@ -243,8 +244,7 @@ bool > action::do_action(config &c) > { > string s = c.expand_string(_cmd.c_str()); > - if (Dflag) > - fprintf(stderr, "Executing '%s'\n", s.c_str()); > + devdlog(LOG_NOTICE, "Executing '%s'\n", s.c_str()); My opinion that this message does not deserve LOG_NOTICE message. LOG_NOTICE Conditions that are not error conditions, but should possi‐ bly be handled specially. I don't think that devd reacting to an event deserves any special handling from an administrator. All LOG_NOTICE messages are logged into /var/log/messages by default. Besides, many actions already explicitly call logger(1) and sometimes that's the only thing that they do. So on a system with default syslog configuration one can see messages like: devd: Executing 'logger Unknown USB device: vendor 0x03f0 product 0x102a bus uhub7' root: Unknown USB device: vendor 0x03f0 product 0x102a bus uhub7 I think that LOG_INFO should be fine for these messages. > my_system(s.c_str()); > return (true); > } > @@ -1078,10 +1090,27 @@ gensighand(int) > romeo_must_die = 1; > } > > +/* > + * Local logging function. Prints to syslog if we're daemonized; syslog > + * otherwise. > + */ Minor nit: there is a typo in this comment. > +static void > +devdlog(int priority, const char* fmt, ...) > +{ > + va_list argp; > + > + va_start(argp, fmt); > + if (dflag) > + vfprintf(stderr, fmt, argp); > + else > + vsyslog(priority, fmt, argp); > + va_end(argp); > +} > + -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?527B8357.5070200>