Date: Tue, 2 Jul 2013 22:30:53 +0200 From: Ed Schouten <ed@80386.nl> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [PATCH] nvmecontrol breaks world Message-ID: <CAJOYFBCWzzT7kSABROsyJsbt%2BN=KhQ3vmW4TJjw3Toxsxu836A@mail.gmail.com> In-Reply-To: <20130702201728.GA68544@troutmask.apl.washington.edu> References: <20130702201728.GA68544@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
2013/7/2 Steve Kargl <sgk@troutmask.apl.washington.edu>: > Could someone (this could even be me, but need approval) please > fix nvmecontrol? off_t doesn't need to be intmax_t, right? Maybe add an explicit cast? Also, the call of malloc(sb.st_size) is not really safe... -- Ed Schouten <ed@80386.nl>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJOYFBCWzzT7kSABROsyJsbt%2BN=KhQ3vmW4TJjw3Toxsxu836A>