Date: Thu, 16 Jan 2003 10:38:07 -0800 (PST) From: Nate Lawson <nate@root.org> To: Bruce Evans <bde@zeta.org.au> Cc: Hidetoshi Shimokawa <simokawa@FreeBSD.org>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwohci.c fwohcivar.h Message-ID: <Pine.BSF.4.21.0301161036320.46845-100000@root.org> In-Reply-To: <20030117052637.I3675-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 17 Jan 2003, Bruce Evans wrote: > On Thu, 16 Jan 2003, Nate Lawson wrote: > > > > - contigfree((void *)(uintptr_t)sc->fc.sid_buf, > > > - OHCI_SIDSIZE, M_DEVBUF); > > > + free((void *)(uintptr_t)sc->fc.sid_buf, M_DEVBUF); > > > > Unnecessary casts (there are others). > > Er, these casts seem to be necessary to break warnings from -Wcast-qual. > sid_buf has type "volatile u_int32_t *". Yes, I've had to discard volatile also (when dealing with freeing an aio_buf). I'm interested why it can't be cast directly to (void *). Why the indirection through unitptr_t? -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0301161036320.46845-100000>