Date: Tue, 2 Jul 2013 22:37:35 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Ed Schouten <ed@80386.nl> Cc: FreeBSD Current <freebsd-current@freebsd.org>, Steve Kargl <sgk@troutmask.apl.washington.edu> Subject: Re: [PATCH] nvmecontrol breaks world Message-ID: <7513EF4A-7808-4DC5-B60E-3AE93ECF85D1@FreeBSD.org> In-Reply-To: <CAJOYFBCWzzT7kSABROsyJsbt%2BN=KhQ3vmW4TJjw3Toxsxu836A@mail.gmail.com> References: <20130702201728.GA68544@troutmask.apl.washington.edu> <CAJOYFBCWzzT7kSABROsyJsbt%2BN=KhQ3vmW4TJjw3Toxsxu836A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 2, 2013, at 22:30, Ed Schouten <ed@80386.nl> wrote: > 2013/7/2 Steve Kargl <sgk@troutmask.apl.washington.edu>: >> Could someone (this could even be me, but need approval) please >> fix nvmecontrol? >=20 > off_t doesn't need to be intmax_t, right? Maybe add an explicit cast? Yes, that is what Bruce has suggested for off_t many times in the past. = :-) > Also, the call of malloc(sb.st_size) is not really safe... Sure, but that does not break buildworld (for gcc users, I assume? the = tinderboxes are all green). -Dimitry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7513EF4A-7808-4DC5-B60E-3AE93ECF85D1>