Date: Tue, 30 Jul 1996 14:52:35 -0700 (MST) From: Terry Lambert <terry@lambert.org> To: ache@nagual.ru (=?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?=) Cc: mihoko@pa.yokogawa.co.jp, freebsd-hackers@FreeBSD.org Subject: Re: patch for the 'sgetrune' of EUC encoding Message-ID: <199607302152.OAA00735@phaeton.artisoft.com> In-Reply-To: <199607260346.HAA01313@nagual.ru> from "=?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?=" at Jul 26, 96 07:46:26 am
next in thread | previous in thread | raw e-mail | index | archive | help
> > That is, The library function 'mblen(3)' doesn't return the error
> > when the second byte is not set MSB.
> > I make the following patch for this problem.
>
> ...
>
> > + /* '0x80-0x9f' are control codes */
> > + if ((c = (unsigned char)*string++) < 0xa0) {
>
> I dislike this hardcoded assumption, because it makes sgetrune
> very charset-depended without proper configuration knobs.
> I.e. if it plans to sense control codes, it must be iscntrl()
> instead.
> Could you change this thing?
Hee hee! 8-). I wondered how long this would last before the KOI-8
people cake out against it... if only they were using the ISO standard
for Coptic languages instead... }B-}.
Terry Lambert
terry@lambert.org
---
Any opinions in this posting are my own and not those of my present
or previous employers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199607302152.OAA00735>