Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Feb 2009 19:07:56 +0100
From:      Ed Schouten <ed@80386.nl>
To:        hackers@FreeBSD.org
Subject:   Renaming all symbols in libmp(3)
Message-ID:  <20090226180756.GX19161@hoeg.nl>

next in thread | raw e-mail | index | archive | help

--nKvJs6ze6az+4fwY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello all,

As you may have read some days ago, work has started to make the FreeBSD
base system compile better with clang, the BSD licensed C compiler from
the LLVM project.

One of the reasons why we can't compile the base system yet, is because
some applications in the base system (keyserv, newkey, chkey, libtelnet)
won't compile, because a library they depend (libmp)on has a function
called pow(). By default, LLVM has a built-in prototype of pow(),
similar to GCC. Unlike GCC, LLVM raises a compiler error by default. The
manual page also mentions this issue.

After some talking on IRC, I think the best solution would be to rename
all functions in libmp. Even though this may sound very awful at first,
it seems the competition has done this as well:

	http://docs.sun.com/app/docs/doc/819-2246/mp-3mp?a=3Dview

I'm not saying that if the Solaris developers jump off a cliff, we
should do the same, but looking at the amount of applications that
depend on libmp (almost none), I think it's the only definitive
solution.

So this is the patch I propose to commit to SVN one of these days:

	http://80386.nl/pub/mp.diff

Because this also reduces some warnings when compiling stuff with GCC,
I've increased WARNS in various Makefiles. I've also increased the
SHLIB_MAJOR and __FreeBSD_version.

Any comments?

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--nKvJs6ze6az+4fwY
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkmm2nwACgkQ52SDGA2eCwWZvgCfYyJdyqMz5UzrAVrDY+r9bpCz
HUcAni1z3hAWoNlBlXuX2PMvOlmeL3wp
=43g2
-----END PGP SIGNATURE-----

--nKvJs6ze6az+4fwY--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090226180756.GX19161>