Date: Thu, 2 Nov 2006 23:41:36 GMT From: Matt Jacob <mjacob@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 109082 for review Message-ID: <200611022341.kA2Nfav6093539@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=109082 Change 109082 by mjacob@newisp on 2006/11/02 23:40:47 Only compare 36 bytes of inquiry data for Domain Validation purposes. We still alloc and fetch for the whole N bytes. Affected files ... .. //depot/projects/newisp/cam/cam_xpt.c#9 edit Differences ... ==== //depot/projects/newisp/cam/cam_xpt.c#9 (text+ko) ==== @@ -6270,7 +6270,6 @@ { struct scsi_inquiry_data *nbuf; struct ccb_scsiio *csio; - int iqlen = SID_ADDITIONAL_LENGTH(&path->device->inq_data); if ((done_ccb->ccb_h.status & CAM_DEV_QFRZN) != 0) { /* Don't wedge the queue */ @@ -6279,7 +6278,7 @@ } csio = &done_ccb->csio; nbuf = (struct scsi_inquiry_data *)csio->data_ptr; - if (bcmp(nbuf, &path->device->inq_data, iqlen) != 0) { + if (bcmp(nbuf, &path->device->inq_data, SHORT_INQUIRY_LENGTH)) { xpt_print_path(path); printf("inquiry fails comparison at DV%d step\n", softc->action == PROBE_INQUIRY_BASIC_DV1? 1 : 2);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611022341.kA2Nfav6093539>