Date: Thu, 01 Nov 2012 16:41:38 +0100 From: Guido Falsi <madpilot@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r306797 - head/emulators/bochs Message-ID: <50929832.9070400@FreeBSD.org> In-Reply-To: <20121101134842.GA13708@FreeBSD.org> References: <201211011133.qA1BXdZE082128@svn.freebsd.org> <20121101134842.GA13708@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/01/12 14:48, Alexey Dokuchaev wrote: > On Thu, Nov 01, 2012 at 11:33:39AM +0000, Guido Falsi wrote: >> New Revision: 306797 >> URL: http://svn.freebsd.org/changeset/ports/306797 >> >> Log: >> - Replace usage of !${PORT_OPTIONS:MFOO} with empty(PORT_OPTIONS:MFOO) > > Any reason for doing it this way? AFAIK both forms are equivalent (in fact > I prefer the ! one, but with a space after exclamation mark). I have no preference, but the porter's handbook reports the empty() form as THE one. Most ports are following the examples there so I was conforming to it. To tell the truth I'm quite sure that I was the one who wrote the old lines when converting it to optionsng, at the time thee porter's handbook had still not been updated with optionsng examples. -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50929832.9070400>