Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Jun 2016 18:49:05 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 210576] [new feature] Mk/bsd.options.mk: opt_CMAKE_BOOL
Message-ID:  <bug-210576-13@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210576

            Bug ID: 210576
           Summary: [new feature] Mk/bsd.options.mk: opt_CMAKE_BOOL
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr@FreeBSD.org
          Reporter: adamw@FreeBSD.org
                CC: freebsd-ports-bugs@FreeBSD.org

Created attachment 171795
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D171795&action=
=3Dedit
opt_CMAKE_BOOL

Many ports that use cmake have to enable or disable boolean features.

ex.:
[adamw@apnoea ~] grep BOOL /usr/ports/audio/libsoxr/Makefile
CMAKE_MAKE_ARGS+=3D       -DWITH_LSR_BINDINGS:BOOL=3DON \
                        -DBUILD_SHARED_LIBS:BOOL=3DON
OPENMP_CMAKE_ON=3D        -DWITH_OPENMP:BOOL=3DON
OPENMP_CMAKE_OFF=3D       -DWITH_OPENMP:BOOL=3DOFF
SIMD_CMAKE_OFF=3D         -DWITH_CR32S:BOOL=3DOFF \
                        -DWITH_CR64S:BOOL=3DOFF
AVFFT_CMAKE_ON=3D         -DWITH_AVFFT:BOOL=3DON
AVFFT_CMAKE_OFF=3D        -DWITH_AVFFT:BOOL=3DOFF
PFFFT_CMAKE_ON=3D         -DWITH_PFFFT:BOOL=3DON
PFFFT_CMAKE_OFF=3D        -DWITH_PFFFT:BOOL=3DOFF

By my count, there are about 225 ports that use this construct.

The attached patch adds a opt_CMAKE_BOOL helper. It makes the above be:

OPENMP_CMAKE_BOOL=3D    OPENMP
AVFFT_CMAKE_BOOL=3D     WITH_AVFFT
PFFFT_CMAKE_BOOL=3D     PFFFT

It only saves one line at a time, but it saves a lot of typing.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210576-13>