Date: Wed, 31 Dec 2014 22:16:53 -0700 From: Warner Losh <imp@bsdimp.com> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: svn-src-head@freebsd.org, Warner Losh <imp@FreeBSD.org>, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Dimitry Andric <dim@FreeBSD.org> Subject: Re: svn commit: r276488 - in head: share/mk sys/arm/broadcom/bcm2835 sys/conf Message-ID: <743CF9C2-4C38-44CF-8AF8-BD2EF8EBCAD7@bsdimp.com> In-Reply-To: <A002DA3A-0047-4F83-8896-25AEEBF489A3@gmail.com> References: <201501010200.t01205Ge007058@svn.freebsd.org> <760D3407-921D-4249-9DC2-74610FA46920@FreeBSD.org> <27B917EC-CB35-4BF6-AB8F-4CBF56EC3E41@bsdimp.com> <E1FA7448-844B-4454-8C2C-5592198D0570@gmail.com> <FC1DD917-D28C-44B8-9BE8-45A57F4A9EA6@bsdimp.com> <E041E7F2-CC45-4D7B-912F-E5F86772E44A@gmail.com> <A002DA3A-0047-4F83-8896-25AEEBF489A3@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_5846770E-0635-4D5D-8332-3CEE8270516C
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=windows-1252
> On Dec 31, 2014, at 10:12 PM, Garrett Cooper <yaneurabeya@gmail.com> =
wrote:
>=20
> On Dec 31, 2014, at 20:44, Garrett Cooper <yaneurabeya@gmail.com> =
wrote:
>=20
>> On Dec 31, 2014, at 20:25, Warner Losh <imp@bsdimp.com> wrote:
>=20
> =85
>=20
>>> This change is wrong. bsd.sys.mk was eliminated on purpose, dammit.
>>=20
>> Sorry. Should have asked first. Now the build is broken on all =
architectures :/. What next?
>=20
> Also, that code has been in there for over a decade. It seems a bit =
dangerous to remove it without at least a ports -exp or make tinderbox =
run=85
True. However, this code has been wrong for a very long time since the =
WARNS kris added were just for user land. Too bad the std stuff got =
mixed in over the years.
Warner
> $ svn blame -r 231834 share/mk/bsd.kmod.mk | less
> 60963 peter # $FreeBSD$
> 60963 peter
> 60963 peter # Search for kernel source tree in standard places.
> 130835 pjd .for _dir in ${.CURDIR}/../.. ${.CURDIR}/../../.. =
${.CURDIR}/../../../.. \
> 183736 imp ${.CURDIR}/../../../../.. /sys /usr/src/sys
> 130835 pjd .if !defined(SYSDIR) && exists(${_dir}/kern/) && =
exists(${_dir}/conf/kmod.mk)
> 60963 peter SYSDIR=3D ${_dir}
> 60963 peter .endif
> 60963 peter .endfor
> 130835 pjd .if !defined(SYSDIR) || !exists(${SYSDIR}/kern/) || =
\
> 130835 pjd !exists(${SYSDIR}/conf/kmod.mk)
> 231834 imp .error Unable to locate the kernel source tree. Set =
SYSDIR to override.
> 60963 peter .endif
> 60963 peter
> 60965 peter .include "${SYSDIR}/conf/kmod.mk"
> 76861 kris
> 76861 kris .include <bsd.sys.mk>
> [ngie@fuji-current-amd64 /usr/src.svn]$ svn log -r 76861
> =
------------------------------------------------------------------------
> r76861 | kris | 2001-05-19 16:18:21 -0700 (Sat, 19 May 2001) | 8 lines
>=20
> Bring in the WARNS directive from NetBSD, localized in a new =
bsd.sys.mk
> to avoid polluting sys.mk. This directive controls the addition of
> compiler warning flags to CFLAGS in a relatively compiler-neutral =
manner.
>=20
> The idea is that WARNS can be set in Makefile.inc or in individual
> Makefiles as they become clean, to prevent the introduction of new
> warnings in the code. -Werror is added by default
>=20
> =
------------------------------------------------------------------------
--Apple-Mail=_5846770E-0635-4D5D-8332-3CEE8270516C
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJUpNhFAAoJEGwc0Sh9sBEAw6AP/Rus2cyQNgRiBBJrRtG0KuU8
mTptCuUnmBS4NBQBAEMuexDYxzWxaamsKiTlkgJhnjfu2s0p/VPw7deqZJsYq0EW
7lNijQf0cbDRQVK89oEUkSf9F2JBtwpqYSSrS5LpL5LE60ghlxh3bf0ZL1bI2GSn
7VizZa6TDj3RTfB+FWXmUZoph8CypmKsBH+9ofLCdHAUeD4jLM/btZYY9zCG0UCt
JEpy433YWT4bCCQv6sR+2J8X2bKTcfnaPbk/gxYQBDV6fUilD2bRCJSW/L7c1TOI
98kR7dcCtxMb2NBLe7Myyx5v7jSxQMftHrfrKBTZPF/+WAJTuxPwdUt9KyRwB9gm
C2fIPh+xLl2YBmBARriKPKEy5yM5Dbhl1loO+QuskRjgc6wqssMAjnPVMrKnBnia
UZZRwRLTjEXn1etp6zcv9Vp6hKUbYTKVflb4mFAtcZO9gJZ50GwzO2GROGX6OLK0
ZSeKweZcUf3uGWJBvHYKPdbYO9veoyfUI2NJZ0sEB+QsD4VM3N6++JEeYKfoDR/R
cbzRBHlzFeQlxHMdxZAhkWexOA7XfzqNKc1uMtu+eytyXQede0qVnyq4AY5o8Chm
xmPQABy+0MW3u0J10U22DoBMCateRNOnz1y+ElRkpOUlzBBi3i/fB7HoaM1Lx6XR
Ljk96E65Fo/96ICXGk1s
=hJeM
-----END PGP SIGNATURE-----
--Apple-Mail=_5846770E-0635-4D5D-8332-3CEE8270516C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?743CF9C2-4C38-44CF-8AF8-BD2EF8EBCAD7>