Date: Sun, 12 Jul 2015 11:12:12 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 201167] units(1) corrupts terminal when run via $() Message-ID: <bug-201167-8-xXCLS1ml7x@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-201167-8@https.bugs.freebsd.org/bugzilla/> References: <bug-201167-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201167 Jilles Tjoelker <jilles@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jilles@FreeBSD.org --- Comment #4 from Jilles Tjoelker <jilles@FreeBSD.org> --- The corruption is because units does not shut down libedit via el_end(). The el_end() call is dead code, since the loop exits via exit(), not break. Other issues: the (inhistory == 0) check is dead code since it has already crashed before that point; it should be moved directly after the history_init() call. Also, the history_end() call should probably be after the el_end() call, not before. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-201167-8-xXCLS1ml7x>