Date: Thu, 16 Jan 2003 14:20:23 -0800 From: "Sam Leffler" <sam@errno.com> To: "Justin T. Gibbs" <gibbs@scsiguy.com>, "Nate Lawson" <nate@root.org>, "Hidetoshi Shimokawa" <simokawa@FreeBSD.org> Cc: <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwohci.c fwohcivar.h Message-ID: <20e801c2bdad$770d56f0$5a557f42@errno.com> References: <Pine.BSF.4.21.0301161007080.46845-100000@root.org> <621240000.1042754436@aslan.btc.adaptec.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> >> Modified files: > >> sys/dev/firewire firewire.c fwdev.c fwohci.c fwohcivar.h > >> Log: > >> Improve memory allocation. > >> - Don't use contigmalloc() and allocate page by page to avoid > >> allocation failure. > >> - allocate buffer by PAGE_SIZE. > > > > Some comments. > > > >> - contigfree((void *)(uintptr_t)sc->fc.sid_buf, > >> - OHCI_SIDSIZE, M_DEVBUF); > >> + free((void *)(uintptr_t)sc->fc.sid_buf, M_DEVBUF); > > malloced buffers are not guaranteed to be accessable by a device. > Use bus dma instead. > New drivers should use bus_dma. I recently hit an issue like this with jumbo mbufs not being handled by the bge driver because it doesn't use bus dma. Sam To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20e801c2bdad$770d56f0$5a557f42>