Date: Tue, 6 Jul 2004 17:52:54 +0200 From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: David Bremner <bremner@unb.ca> Cc: freebsd-ports@freebsd.org Subject: Re: feedback requested for math/gap port reorganization Message-ID: <8B639F71-CF64-11D8-8006-00039312D914@fillmore-labs.com> In-Reply-To: <0thdslupvb.wl@nohost.unb.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
David Bremner wrote: > I wanted to upgrade the port math/gap port. [...] > you can have a look at the whole business in > > http://www.cs.unb.ca/~bremner/gap-ports.tgz You should use DISTFILES instead of DISTNAME= gap4r4 EXTRACT_SUFX= p3.tar.bz2 USE_BZIP2 instead of EXTRACT_CMD= bunzip2 Please use tabs before variable values where possible. You don't need to include bsd.port.pre.mk, bsd.port.mk is sufficient. The subshell in do-install in unnecessary, please use INSTALL_SCRIPT to install the script. You subprograms belong in ${PREFIX}/libexec, not lib, see hier(7). Data belongs in ${DATADIR} or ${PREFIX}/libdata, documentation into ${DOCSDIR}, preferences into ${PREFIX}/etc. Please use portlint(1). math/gap-package is no complete port, so it is not allowed in the ports tree. It shouldn't be too difficult to make a port gap-packages that installs a configurable set of packages, selectable with WITH_* $FreeBSD$ tags should be empty on new ports, stuff like ALL_TARGET:=${ALL_TARGET:C/^all$//} should be only used as a last resort, and only when you are *excatly* know what you are doing. Generally, it is best to avoid := and != in ports Makefiles. -Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8B639F71-CF64-11D8-8006-00039312D914>