Date: Tue, 2 Jul 2013 16:23:10 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Ed Schouten <ed@80386.nl> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [PATCH] nvmecontrol breaks world Message-ID: <20130702232310.GB69299@troutmask.apl.washington.edu> In-Reply-To: <CAJOYFBCWzzT7kSABROsyJsbt%2BN=KhQ3vmW4TJjw3Toxsxu836A@mail.gmail.com> References: <20130702201728.GA68544@troutmask.apl.washington.edu> <CAJOYFBCWzzT7kSABROsyJsbt%2BN=KhQ3vmW4TJjw3Toxsxu836A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 02, 2013 at 10:30:53PM +0200, Ed Schouten wrote: > 2013/7/2 Steve Kargl <sgk@troutmask.apl.washington.edu>: > > Could someone (this could even be me, but need approval) please > > fix nvmecontrol? > > off_t doesn't need to be intmax_t, right? Maybe add an explicit cast? > Also, the call of malloc(sb.st_size) is not really safe... > jimharris committed the patch. I suspect that this is intel code, which needs to be portable to other OS's. Hopefully, he fixes the build soon. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130702232310.GB69299>