Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 20 Dec 2008 21:53:35 GMT
From:      Alberto Villa <villa.alberto@gmail.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/129800: Update port: multimedia/ffmpeg avoid crash in multimedia/kdenlive-kde4[-devel]
Message-ID:  <200812202153.mBKLrZ4D073954@www.freebsd.org>
Resent-Message-ID: <200812202200.mBKM07Mj016555@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         129800
>Category:       ports
>Synopsis:       Update port: multimedia/ffmpeg avoid crash in multimedia/kdenlive-kde4[-devel]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 20 22:00:07 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Alberto Villa
>Release:        FreeBSD 7-stable
>Organization:
>Environment:
FreeBSD echo.hoth 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #5: Mon Dec  8 16:43:10CET 2008     root@:/usr/obj/usr/src/sys/TPR60  i386
>Description:
update libavformat/avidec.c to avoid a crash in inigo, the MLT renderer used by multimedia/kdenlive-kde4[-devel] (just submitted)
the patch has been taken from a new svn version of ffmpeg, so it's code made in ffmpeg and just works
>How-To-Repeat:
import a clip in kdenlive and sometimes this will result in a crash
>Fix:
here is the patch

new files: files/patch-libavformat-avidec.c

Patch attached with submission follows:

diff -ruN ffmpeg.orig/files/patch-libavformat-avidec.c ffmpeg/files/patch-libavformat-avidec.c
--- ffmpeg.orig/files/patch-libavformat-avidec.c	1970-01-01 01:00:00.000000000 +0100
+++ ffmpeg/files/patch-libavformat-avidec.c	2008-12-20 18:35:09.000000000 +0100
@@ -0,0 +1,14 @@
+--- libavformat/avidec.c.old	2008-10-16 10:30:37.000000000 +0000
++++ libavformat/avidec.c	2008-10-16 10:32:22.000000000 +0000
+@@ -1026,8 +1026,9 @@
+             continue;
+ 
+ //        assert(st2->codec->block_align);
+-        assert(st2->time_base.den == ast2->rate);
+-        assert(st2->time_base.num == ast2->scale);
++	assert((int64_t)st2->time_base.num*ast2->rate == (int64_t)st2->time_base.den*ast2->scale);
++//        assert(st2->time_base.den == ast2->rate);
++//        assert(st2->time_base.num == ast2->scale);
+         index = av_index_search_timestamp(
+                 st2,
+                 av_rescale(timestamp, st2->time_base.den*(int64_t)st->time_base.num, st->time_base.den * (int64_t)st2->time_base.num),


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812202153.mBKLrZ4D073954>